Skip to content

fix: Fix cache KeyError #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2022
Merged

fix: Fix cache KeyError #1169

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1e193d
fix: fix cache error when popping from LRUDict
mAxYoLo01 Nov 15, 2022
93cbcd6
ci: correct from checks.
pre-commit-ci[bot] Nov 15, 2022
c0b089a
fix: remove MISSING
mAxYoLo01 Nov 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions interactions/utils/dict_caches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
from collections import OrderedDict
from typing import Generic, TypeVar

from .missing import MISSING

__all__ = ("FIFODict", "LRUDict")

_KT = TypeVar("_KT")
Expand Down Expand Up @@ -45,3 +47,14 @@ def __setitem__(self, key: _KT, value: _VT):
# Prevent buildup over time
while len(self) > self._max_items:
del self[next(iter(self))]

__marker = object()

def pop(self, key: _KT, default: _VT = __marker) -> _VT:
if key in self:
result = self[key]
del self[key]
return result
if default is MISSING:
raise KeyError(key)
return default