From f3b91e6fc9094209d689aa55bb617afe80d38616 Mon Sep 17 00:00:00 2001 From: Chris Perkins Date: Tue, 8 Nov 2022 09:19:29 -0800 Subject: [PATCH] my post-commit fix caused an ABI symbols problem downstream. But the original problem is that the custom specialization of get_info is merely missing an export declaration. If I'm right, or just dumb lucky, then this will fix all downstream failures, including post-commit. And if not, well, the symbol update is correct regardless Signed-off-by: Chris Perkins --- sycl/source/device.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sycl/source/device.cpp b/sycl/source/device.cpp index 45240cc99dc84..b170720aa8fcb 100644 --- a/sycl/source/device.cpp +++ b/sycl/source/device.cpp @@ -128,7 +128,8 @@ device::get_info() const { } // Explicit override. Not fulfilled by #include device_traits.def below. -template <> device device::get_info() const { +template <> +__SYCL_EXPORT device device::get_info() const { // With ONEAPI_DEVICE_SELECTOR the impl.MRootDevice is preset and may be // overridden (ie it may be nullptr on a sub-device) The PI of the sub-devices // have parents, but we don't want to return them. They must pretend to be