Skip to content

[SYCL][CUDA] Add missing barrier to collectives #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 14, 2021
Merged

[SYCL][CUDA] Add missing barrier to collectives #2990

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09b4fe3
[SYCL][CUDA] Add missing barrier to collectives
Pennycook Jan 4, 2021
14438de
[SYCL] Add regression test for collective barrier
Pennycook Jan 11, 2021
d7145ab
[SYCL][NFC] Move test from regression to on-device
Pennycook Jan 11, 2021
73a8788
Update sycl/test/on-device/back_to_back_collectives.cpp
bader Jan 13, 2021
036e712
Update sycl/test/on-device/back_to_back_collectives.cpp
bader Jan 13, 2021
6d9918b
[SYCL] Derive max WG size from kernel query
Pennycook Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libclc/ptx-nvidiacl/libspirv/group/collectives.cl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ __CLC_SUBGROUP_COLLECTIVE(FMax, __CLC_MAX, double, -DBL_MAX)
result = OP(sg_x, scratch[sg_id - 1]); \
} \
} \
__spirv_ControlBarrier(Workgroup, 0, 0); \
return result; \
}

Expand Down