-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL][E2E] Add InlineAsm/lit.local.cfg
to clean up REQUIRES
/UNSUPPORTED
#16311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1,5 +1,4 @@ | |||
// UNSUPPORTED: cuda || hip | |||
// REQUIRES: gpu,linux,sg-16 | |||
// REQUIRES: sg-16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is sg-16
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, will this be impacted by #16314 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is
sg-16
?
Subgroup size 16, the test uses sycl::reqd_sub_group_size(16)
also, will this be impacted by #16314 ?
Nikita did mention that here #16314 (comment)
Hi @cperkinsintel! Could you please take one more look? |
@cperkinsintel / @intel/llvm-reviewers-runtime Could you have another look at this. |
@@ -0,0 +1,2 @@ | |||
config.unsupported_features += ['cuda', 'hip'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, that should be REQURIES: <intel-gpu>
, although I don't know if that's possible. Also, it might be a good idea to have an extra directory for that (InlineAsm/IntelGPU
).
@aelovikov-intel There were just two tests that didnt have |
Because "empty" inline asm can be compiled there? I still think we should be creating a dedicated |
@aelovikov-intel I checked locally, the tests that were not marked as unsupported for hip are actually still unsupported and fail to build for hip because of the subgroup size requirements. This means every test in this folder was unsupported for cuda/hip, so instead of making the |
I can live with that. |
All test in this folder use
REQUIRES: gpu,linux
andUNSUPPORTED: cuda, hip
. So using a lit.local.cfg file makes sense here.