Skip to content

[SYCL][E2E] Add InlineAsm/lit.local.cfg to clean up REQUIRES/UNSUPPORTED #16311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 28, 2025

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Dec 9, 2024

All test in this folder use REQUIRES: gpu,linux and UNSUPPORTED: cuda, hip. So using a lit.local.cfg file makes sense here.

@@ -1,5 +1,4 @@
// UNSUPPORTED: cuda || hip
// REQUIRES: gpu,linux,sg-16
// REQUIRES: sg-16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is sg-16 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, will this be impacted by #16314 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is sg-16 ?

Subgroup size 16, the test uses sycl::reqd_sub_group_size(16)

also, will this be impacted by #16314 ?

Nikita did mention that here #16314 (comment)

@KornevNikita
Copy link
Contributor

Hi @cperkinsintel! Could you please take one more look?

@ayylol ayylol requested a review from cperkinsintel January 2, 2025 17:05
@ayylol
Copy link
Contributor Author

ayylol commented Jan 2, 2025

@cperkinsintel / @intel/llvm-reviewers-runtime Could you have another look at this.

@@ -0,0 +1,2 @@
config.unsupported_features += ['cuda', 'hip']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, that should be REQURIES: <intel-gpu>, although I don't know if that's possible. Also, it might be a good idea to have an extra directory for that (InlineAsm/IntelGPU).

@ayylol
Copy link
Contributor Author

ayylol commented Jan 20, 2025

@aelovikov-intel There were just two tests that didnt have UNSUPPORTED: hip (asm_8_empty.cpp, and asm_16_empty.cpp). Would you happen to know why these two are exceptions, I see you were the one that last changed these lines?

@aelovikov-intel
Copy link
Contributor

@aelovikov-intel There were just two tests that didnt have UNSUPPORTED: hip (asm_8_empty.cpp, and asm_16_empty.cpp). Would you happen to know why these two are exceptions, I see you were the one that last changed these lines?

Because "empty" inline asm can be compiled there? I still think we should be creating a dedicated InlineAsm/IntelGPU folder and moving all but these two tests there.

@ayylol
Copy link
Contributor Author

ayylol commented Jan 27, 2025

@aelovikov-intel I checked locally, the tests that were not marked as unsupported for hip are actually still unsupported and fail to build for hip because of the subgroup size requirements. This means every test in this folder was unsupported for cuda/hip, so instead of making the IntelGPU subfolder i just added REQUIRES: target-spir to the lit.local.cfg file

@aelovikov-intel
Copy link
Contributor

so instead of making the IntelGPU subfolder i just added REQUIRES: target-spir to the lit.local.cfg file

I can live with that.

@aelovikov-intel aelovikov-intel merged commit 8324bb2 into intel:sycl Jan 28, 2025
16 checks passed
@ayylol ayylol deleted the inlineasm-litlocal branch January 29, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants