Skip to content

Commit 9d0e352

Browse files
authored
[SYCL] Don't dump IR and dot files by default in the LowerWGScope pass (#2887)
1 parent e9423ff commit 9d0e352

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

llvm/lib/SYCLLowerIR/LowerWGScope.cpp

+11-7
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ static constexpr char PFWI_MD[] = "parallel_for_work_item";
106106
static cl::opt<int> Debug("sycl-lower-wg-debug", llvm::cl::Optional,
107107
llvm::cl::Hidden,
108108
llvm::cl::desc("Debug SYCL work group code lowering"),
109-
llvm::cl::init(10));
109+
llvm::cl::init(1));
110110

111111
namespace {
112112
class SYCLLowerWGScopeLegacyPass : public FunctionPass {
@@ -375,25 +375,29 @@ using LocalsSet = SmallPtrSet<AllocaInst *, 4>;
375375

376376
static void copyBetweenPrivateAndShadow(Value *L, GlobalVariable *Shadow,
377377
IRBuilder<> &Builder, bool Loc2Shadow) {
378+
assert(isa<PointerType>(L->getType()));
378379
Type *T = nullptr;
379380
MaybeAlign LocAlign(0);
380381

381382
if (const auto *AI = dyn_cast<AllocaInst>(L)) {
382383
T = AI->getAllocatedType();
383384
LocAlign = MaybeAlign(AI->getAlignment());
384385
} else {
385-
if (cast<Argument>(L)->hasByValAttr()) {
386-
T = cast<Argument>(L)->getParamByValType();
387-
LocAlign = MaybeAlign(cast<Argument>(L)->getParamAlignment());
386+
auto Arg = cast<Argument>(L);
387+
if (Arg->hasByValAttr()) {
388+
T = Arg->getParamByValType();
389+
LocAlign = MaybeAlign(Arg->getParamAlignment());
388390
} else {
389-
Type *Ty = cast<Argument>(L)->getType();
391+
Type *Ty = Arg->getType();
390392
Module &M = *Shadow->getParent();
391393
LocAlign = M.getDataLayout().getValueOrABITypeAlignment(
392-
MaybeAlign(cast<Argument>(L)->getParamAlignment()), Ty);
393-
T = cast<Argument>(L)->getType()->getPointerElementType();
394+
MaybeAlign(Arg->getParamAlignment()), Ty);
395+
T = Arg->getType()->getPointerElementType();
394396
}
395397
}
396398

399+
assert(T && "Unexpected type");
400+
397401
if (T->isAggregateType()) {
398402
// TODO: we should use methods which directly return MaybeAlign once such
399403
// are added to LLVM for AllocaInst and GlobalVariable

0 commit comments

Comments
 (0)