Skip to content

Commit 8e42124

Browse files
committed
[HIP] Avoid append dup args in TranslateArgs after b37be0e
b37be0e started to TranslateArgs for SYCL too, so we may endup getting dup args, eg: /__w/llvm/llvm/build/bin/clang --driver-mode=g++ -Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch=gfx906 -fsycl-device-only -fsycl-targets=amd_gpu_gfx90a -S -Xclang -emit-llvm /__w/llvm/llvm/src/sycl/test/check_device_code/hip/matrix/matrix-hip-double-double-test.cpp -o -| FileCheck /__w/llvm/llvm/src/sycl/test/check_device_code/hip/matrix/matrix-hip-double-double-test.cpp executed command: /__w/llvm/llvm/build/bin/clang --driver-mode=g++ -Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch=gfx906 -fsycl-device-only -fsycl-targets=amd_gpu_gfx90a -S -Xclang -emit-llvm /__w/llvm/llvm/src/sycl/test/check_device_code/hip/matrix/matrix-hip-double-double-test.cpp -o - .---command stderr------------ | error: '-emit-llvm' action ignored; '-emit-llvm' action specified previously
1 parent 9e9082c commit 8e42124

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

clang/lib/Driver/ToolChains/HIPAMD.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,8 @@ HIPAMDToolChain::TranslateArgs(const llvm::opt::DerivedArgList &Args,
344344
const OptTable &Opts = getDriver().getOpts();
345345

346346
for (Arg *A : Args) {
347-
if (!shouldSkipSanitizeOption(*this, Args, BoundArch, A))
347+
if (!shouldSkipSanitizeOption(*this, Args, BoundArch, A) &&
348+
!llvm::is_contained(*DAL, A))
348349
DAL->append(A);
349350
}
350351

0 commit comments

Comments
 (0)