[SYCL] Some changes were missed in the rebase because the file was

moved.

Signed-off-by: Garima Gupta <[email protected]>

Author: garimagu

sycl/plugins/opencl/pi_opencl.cpp

@@ -70,7 +70,11 @@ pi_result OCL(piextDeviceSelectBinary)(
     pi_device_binary *images, pi_uint32 num_images,
     pi_device_binary *selected_image) {
 
-  // TODO dummy implementation.
+  // TODO: this is a bare-bones implementation for choosing a device image
+  // that would be compatible with the targeted device. An AOT-compiled
+  // image is preferred over SPIRV for known devices (i.e. Intel devices)
+  // The implementation makes no effort to differentiate between multiple images
+  // for the given device, and simply picks the first one compatible
   // Real implementaion will use the same mechanism OpenCL ICD dispatcher
   // uses. Something like:
   //   PI_VALIDATE_HANDLE_RETURN_HANDLE(ctx, PI_INVALID_CONTEXT);
@@ -79,8 +83,56 @@ pi_result OCL(piextDeviceSelectBinary)(
   // where context->dispatch is set to the dispatch table provided by PI
   // plugin for platform/device the ctx was created for.
 
-  *selected_image = num_images > 0 ? images[0] : nullptr;
-  return PI_SUCCESS;
+  // Choose the binary target for the provided device
+  const char *image_target = nullptr;
+  // Get the type of the device
+  cl_device_type device_type;
+  cl_int ret_err = clGetDeviceInfo(cast<cl_device_id>(device), CL_DEVICE_TYPE,
+                                   sizeof(cl_device_type), &device_type, nullptr);
+  if (ret_err != CL_SUCCESS) {
+    *selected_image = nullptr;
+    return cast<pi_result>(ret_err);
+  }
+
+  switch (device_type) {
+  // TODO: Factor out vendor specifics into a separate source
+  // E.g. sycl/source/detail/vendor/intel/detail/pi_opencl.cpp?
+
+  // We'll attempt to find an image that was AOT-compiled
+  // from a SPIR-V image into an image specific for:
+
+  case CL_DEVICE_TYPE_CPU: // OpenCL 64-bit CPU
+    image_target = PI_DEVICE_BINARY_TARGET_SPIRV64_X86_64;
+    break;
+  case CL_DEVICE_TYPE_GPU: // OpenCL 64-bit GEN GPU
+    image_target = PI_DEVICE_BINARY_TARGET_SPIRV64_GEN;
+    break;
+  case CL_DEVICE_TYPE_ACCELERATOR: // OpenCL 64-bit FPGA
+    image_target = PI_DEVICE_BINARY_TARGET_SPIRV64_FPGA;
+    break;
+  default:
+    // Otherwise, we'll attempt to find and JIT-compile
+    // a device-independent SPIR-V image
+    image_target = PI_DEVICE_BINARY_TARGET_SPIRV64;
+    break;
+  }
+
+  // Find the appropriate device image, fallback to spirv if not found
+  pi_device_binary fallback = nullptr;
+  for (size_t i = 0; i < num_images; ++i) {
+    if (strcmp(images[i]->DeviceTargetSpec, image_target) == 0) {
+      *selected_image = images[i];
+      return PI_SUCCESS;
+    }
+    if (strcmp(images[i]->DeviceTargetSpec, PI_DEVICE_BINARY_TARGET_SPIRV64) ==
+        0)
+      fallback = images[i];
+  }
+  // Points to a spirv image, if such indeed was found
+  if ((*selected_image = fallback))
+    return PI_SUCCESS;
+  // No image can be loaded for the given device
+  return PI_INVALID_BINARY;
 }
 
 pi_result OCL(piQueueCreate)(pi_context context, pi_device device,