-
Notifications
You must be signed in to change notification settings - Fork 3
feat(hermes): add staked-ada endpoint #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
97f76d3 to
eb0fc49
Compare
fd096ac to
87fc1be
Compare
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/hermes/aido/499/staked-ada-endpoint |
65f8bb6 to
c1a7452
Compare
…r test is finished
…ve unused staked_ada module
c1a7452 to
e1d9775
Compare
rafal-ch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of small comments.
I assumed that most of the bussiness-logic code (for example, in get_txo_assets()) has just been copied from gateway, so I didn't check these parts thoroughly.
cong-or
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
rafal-ch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Good stuff.
Description
Creates staked-ada endpoint for voting power tracking.
Related Issue(s)
Closes #499
Description of Changes
Related Pull Requests
#593 #577 #571
Please confirm the following checks