Skip to content

Conversation

@aido-mth
Copy link
Contributor

@aido-mth aido-mth commented Oct 23, 2025

Description

Creates staked-ada endpoint for voting power tracking.

Related Issue(s)

Closes #499

Description of Changes

  • Added gateway configuration for staked-ada endpoint
  • Added staked-ada endpoint configuration
  • Updated justfile for athena build
  • Added utoipa to provide api doc
  • Added integration test for staked-ada endpoint

Related Pull Requests

#593 #577 #571

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@aido-mth aido-mth self-assigned this Oct 23, 2025
@aido-mth aido-mth added review me PR is ready for review squad: hermetics Hermes Backend, System Development & Integration Team rr: hermetics Required review by hermes team labels Oct 23, 2025
@aido-mth aido-mth moved this from New to 👀 In review in Catalyst Oct 23, 2025
@aido-mth aido-mth marked this pull request as ready for review October 23, 2025 18:48
@aido-mth aido-mth force-pushed the aido/499/staked-ada-endpoint branch from 97f76d3 to eb0fc49 Compare October 24, 2025 08:44
@aido-mth aido-mth force-pushed the aido/499/staked-ada-endpoint branch 2 times, most recently from fd096ac to 87fc1be Compare November 4, 2025 08:08
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/hermes/aido/499/staked-ada-endpoint

@aido-mth aido-mth force-pushed the aido/499/staked-ada-endpoint branch 2 times, most recently from 65f8bb6 to c1a7452 Compare November 5, 2025 11:43
@aido-mth aido-mth force-pushed the aido/499/staked-ada-endpoint branch from c1a7452 to e1d9775 Compare November 6, 2025 14:55
Copy link
Contributor

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of small comments.

I assumed that most of the bussiness-logic code (for example, in get_txo_assets()) has just been copied from gateway, so I didn't check these parts thoroughly.

cong-or
cong-or previously approved these changes Nov 7, 2025
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Good stuff.

@aido-mth aido-mth enabled auto-merge (squash) November 7, 2025 14:14
@aido-mth aido-mth merged commit 3268a10 into main Nov 7, 2025
53 checks passed
@aido-mth aido-mth deleted the aido/499/staked-ada-endpoint branch November 7, 2025 15:01
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review rr: hermetics Required review by hermes team squad: hermetics Hermes Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Implementing the Endpoints following what catalyst gateway has.

4 participants