From dbf9cae15be5e80d35b479b443f5d3b09f446732 Mon Sep 17 00:00:00 2001 From: Mateusz Galazyn Date: Wed, 7 May 2025 17:58:36 +0200 Subject: [PATCH] Use `Inject` draft --- "docs/ADR-008-Use-RIO-in-cardano\342\200\220cli.md" | 5 ++--- docs/ADR-009-cardano-api-exports-convention.md | 2 +- docs/ADR-010-cardano-api-script-witness-api.md | 2 +- ...4-Use-Inject-internally-for-total-conversions.md | 13 +++++++++++++ 4 files changed, 17 insertions(+), 5 deletions(-) create mode 100644 docs/ADR-014-Use-Inject-internally-for-total-conversions.md diff --git "a/docs/ADR-008-Use-RIO-in-cardano\342\200\220cli.md" "b/docs/ADR-008-Use-RIO-in-cardano\342\200\220cli.md" index 7e5bfd6..0e3482b 100644 --- "a/docs/ADR-008-Use-RIO-in-cardano\342\200\220cli.md" +++ "b/docs/ADR-008-Use-RIO-in-cardano\342\200\220cli.md" @@ -1,6 +1,5 @@ # Status -- [x] Adopted 2025/02/10 - +- [x] Adopted 2025-02-10 # Required Reading @@ -183,4 +182,4 @@ The purpose of `CustomCliException` is to represent explicitly thrown, structure # Consequences - This should dramatically improve our code's composability and remove many unnecessary error types. - Readability concerning what errors can be thrown will be negatively impacted. However, `ExceptT` already lies about what exceptions can be thrown because it is not limited to the error type stated in `ExceptT`'s type signature. In other words, `IO` can implicitly throw other `Exception`s. -- Initially, this will be adopted under the "compatible" group of commands so `cardano-cli` will have a design split temporarily. Once we are happy with the result we will propagate to the rest of `cardano-cli` \ No newline at end of file +- Initially, this will be adopted under the "compatible" group of commands so `cardano-cli` will have a design split temporarily. Once we are happy with the result we will propagate to the rest of `cardano-cli` diff --git a/docs/ADR-009-cardano-api-exports-convention.md b/docs/ADR-009-cardano-api-exports-convention.md index eec200a..83b9706 100644 --- a/docs/ADR-009-cardano-api-exports-convention.md +++ b/docs/ADR-009-cardano-api-exports-convention.md @@ -1,6 +1,6 @@ # Status -✅ Accepted 21-02-2025 +✅ Accepted 2025-02-21 # Context diff --git a/docs/ADR-010-cardano-api-script-witness-api.md b/docs/ADR-010-cardano-api-script-witness-api.md index 1d98281..a3863fc 100644 --- a/docs/ADR-010-cardano-api-script-witness-api.md +++ b/docs/ADR-010-cardano-api-script-witness-api.md @@ -1,6 +1,6 @@ # Status --[x] Accepted 13-03-2025 +-[x] Accepted 2025-03-13 # Context diff --git a/docs/ADR-014-Use-Inject-internally-for-total-conversions.md b/docs/ADR-014-Use-Inject-internally-for-total-conversions.md new file mode 100644 index 0000000..0f46a8f --- /dev/null +++ b/docs/ADR-014-Use-Inject-internally-for-total-conversions.md @@ -0,0 +1,13 @@ +# Status + +- [ ] Proposed 2024-05-07 + +# Context + +Use `Inject` & `Convert` for internal conversion functions. + +Use dedicated functions with explicit name for exported conversion functions. + +# Decision + +# Consequences