test(e2e): rewards test #441

iadmytro · 2022-09-15T12:05:34Z

E2E test for rewards

packages/e2e/test/local-network/local-network.test.ts

AngelCastilloB

I think this test should be located at test/wallet/SingleAddressWallet/ together with the rest of the SingleAddressWallet tests, maybe in delegation.test.ts? or in a new staking-rewards.test.ts.

packages/e2e/test/local-network/local-network.test.ts

iccicci · 2022-09-21T16:23:03Z

Hi @rhyslbw , @mkazlauskas , @AngelCastilloB , @mirceahasegan ;

the suggestions from all the conversations should be solved;
used TxBuilder in generateTxs as well;
I tried to make the flow as close as possible to the diagram Rhys provided us on slack.

Now I'm keeping my eyes on this and this CI builds to check if the test works on CI as well.

packages/e2e/test/wallet/SingleAddressWallet/staking-rewards.test.ts

mirceahasegan

Great work @iccicci and @iadmytro. 👏
The test, even though complicated, is so easy to read and a good example of how to use the SDK.

packages/e2e/test/wallet/SingleAddressWallet/staking-rewards.test.ts

mkazlauskas

Looking good, just a few minor improvements suggested

packages/e2e/test/wallet/SingleAddressWallet/delegation-rewards.test.ts

packages/e2e/test/wallet/SingleAddressWallet/delegation.test.ts

iccicci · 2022-09-27T09:16:27Z

Hi @rhyslbw ,

I'm sorry but I'm not able to go on this test.
I added the last step of the test as described in tickets AC (withdraw the reward) but I get an error trying to submit the withdraw tx; at least the error is deterministic and is shared in a CI workflow. I also tried to set the log level to debug as suggested by @mkazlauskas , but it seems this was generating too many logs... I had to stop CI after 3h.

This is not the only problem: once added this test to the test:wallet e2e suite (as suggested in this PR) many other tests in the same suite fail...

I tried to investigate the MissingVkWitnessesError, but I didn't understood how to handle it. I need support on this.

CC @AngelCastilloB , @mirceahasegan

packages/wallet/src/SingleAddressWallet.ts

extraSigner used in nft e2e test was sometimes signing with stake key, while it should only be signing with the key used for minting

ogmios provider sometimes throws this due to websocket being disconnected

interpret UnknownOrIncompleteWithdrawalsError as tx already submitted

packages/e2e/test/wallet/util.ts

packages/e2e/test/wallet/SingleAddressWallet/delegation-rewards.test.ts

packages/e2e/test/wallet/util.ts

AngelCastilloB

LGTM 🚀

rhyslbw

Looks good

packages/e2e/test/wallet/util.ts

packages/e2e/test/wallet/SingleAddressWallet/delegation-rewards.test.ts

rewards were still not generated consistently

some cleanup on delegation-rewards test

since inputs are unordered, jest would sometimes incorrectly fail the test

initializeTx awaits for epoch rollover when near it

by taking into account rewards generated between building tx and submission confirmation

… CI not exiting the issue most likely lies within wallet package and will be easier to reproduce and fix in unit tests once we de-promisify SingleAddressWallet dependencies

…3 by default)

Martynas completed the fixes

iadmytro requested review from AngelCastilloB and rhyslbw September 15, 2022 12:05

iadmytro force-pushed the test/e2e-rewards branch from 4a1f774 to ae8a385 Compare September 15, 2022 12:27

mkazlauskas requested changes Sep 15, 2022

View reviewed changes

packages/e2e/test/local-network/local-network.test.ts Outdated Show resolved Hide resolved

packages/e2e/test/local-network/local-network.test.ts Outdated Show resolved Hide resolved

AngelCastilloB requested changes Sep 15, 2022

View reviewed changes

AngelCastilloB reviewed Sep 15, 2022

View reviewed changes

packages/e2e/test/local-network/local-network.test.ts Outdated Show resolved Hide resolved

mirceahasegan reviewed Sep 16, 2022

View reviewed changes

packages/e2e/test/local-network/local-network.test.ts Outdated Show resolved Hide resolved

mirceahasegan reviewed Sep 16, 2022

View reviewed changes

packages/e2e/test/local-network/local-network.test.ts Outdated Show resolved Hide resolved

mirceahasegan reviewed Sep 22, 2022

View reviewed changes

packages/e2e/test/wallet/SingleAddressWallet/staking-rewards.test.ts Outdated Show resolved Hide resolved

mirceahasegan previously approved these changes Sep 22, 2022

View reviewed changes

mkazlauskas requested changes Sep 22, 2022

View reviewed changes

packages/e2e/test/wallet/SingleAddressWallet/staking-rewards.test.ts Outdated Show resolved Hide resolved

packages/e2e/test/wallet/SingleAddressWallet/staking-rewards.test.ts Outdated Show resolved Hide resolved

iccicci dismissed mirceahasegan’s stale review via d745c4d September 22, 2022 09:53

iccicci force-pushed the test/e2e-rewards branch 3 times, most recently from c9b4c36 to 8ca0385 Compare September 26, 2022 23:29

mkazlauskas previously requested changes Sep 27, 2022

View reviewed changes

iccicci reviewed Sep 28, 2022

View reviewed changes

packages/wallet/src/SingleAddressWallet.ts Outdated Show resolved Hide resolved

iccicci force-pushed the test/e2e-rewards branch from 5399beb to acd6a37 Compare October 11, 2022 07:00

iccicci mentioned this pull request Oct 18, 2022

Fixes: transactions with withdraw #487

Merged

iccicci added 2 commits October 20, 2022 14:04

test(e2e): rewards test

dc2666f

refactor(cardano-services-client): removes error repetition in logs

7687c7c

iccicci force-pushed the test/e2e-rewards branch from acd6a37 to 7687c7c Compare October 20, 2022 12:40

mkazlauskas added 3 commits October 21, 2022 15:02

fix(key-management): don't sign withdrawals for non-own reward accounts

fd9b254

extraSigner used in nft e2e test was sometimes signing with stake key, while it should only be signing with the key used for minting

fix(cardano-services-client): do not re-wrap UnknownTxSubmissionError

a51c9e8

ogmios provider sometimes throws this due to websocket being disconnected

fix(wallet): re-submit 'Unknown' tx submission errors

0d1447f

interpret UnknownOrIncompleteWithdrawalsError as tx already submitted

AngelCastilloB reviewed Oct 23, 2022

View reviewed changes

packages/e2e/test/wallet/util.ts Outdated Show resolved Hide resolved

AngelCastilloB reviewed Oct 23, 2022

View reviewed changes

packages/e2e/test/wallet/SingleAddressWallet/delegation-rewards.test.ts Show resolved Hide resolved

AngelCastilloB reviewed Oct 23, 2022

View reviewed changes

packages/e2e/test/wallet/util.ts Show resolved Hide resolved

AngelCastilloB force-pushed the test/e2e-rewards branch from e8db388 to 91986fd Compare October 24, 2022 04:50

iadmytro force-pushed the test/e2e-rewards branch from 91986fd to 08785cc Compare October 24, 2022 08:49

mkazlauskas force-pushed the test/e2e-rewards branch from 08785cc to c53c1ae Compare October 24, 2022 12:16

mkazlauskas requested review from AngelCastilloB and iccicci October 24, 2022 12:27

AngelCastilloB previously approved these changes Oct 25, 2022

View reviewed changes

rhyslbw requested changes Oct 25, 2022

View reviewed changes

packages/e2e/test/wallet/util.ts Show resolved Hide resolved

packages/e2e/test/wallet/SingleAddressWallet/delegation-rewards.test.ts Show resolved Hide resolved

mkazlauskas and others added 10 commits October 25, 2022 08:28

chore(e2e): decrease jest testTimeout to 25min

230989c

chore(e2e): slow down the network

5e6efb6

rewards were still not generated consistently

test(e2e): hoist some utils out of rewards test

526ae96

some cleanup on delegation-rewards test

test(e2e): improve txChainHistory test consistency

11c1ea0

since inputs are unordered, jest would sometimes incorrectly fail the test

feat(wallet): export default polling interval

b33c3de

fix(e2e): patch wallet to respect epoch boundary

6fe2bfe

initializeTx awaits for epoch rollover when near it

test(e2e): improve delegation test consistency

d50124a

by taking into account rewards generated between building tx and submission confirmation

test(e2e): added a wait for faucet step in the E2E CI

9b65fbc

chore(e2e): add --forceExit jest option as a temporary workaround for…

5e69a6d

… CI not exiting the issue most likely lies within wallet package and will be easier to reproduce and fix in unit tests once we de-promisify SingleAddressWallet dependencies

test(e2e): improve tx confirmation util to wait for n confirmations (…

b7285f7

…3 by default)

mkazlauskas dismissed AngelCastilloB’s stale review via b7285f7 October 25, 2022 05:28

mkazlauskas force-pushed the test/e2e-rewards branch from 4e622b7 to b7285f7 Compare October 25, 2022 05:28

rhyslbw self-requested a review October 25, 2022 05:32

rhyslbw approved these changes Oct 25, 2022

View reviewed changes

AngelCastilloB approved these changes Oct 25, 2022

View reviewed changes

rhyslbw merged commit 26699f7 into master Oct 25, 2022

rhyslbw deleted the test/e2e-rewards branch October 25, 2022 06:22

test(e2e): rewards test #441

test(e2e): rewards test #441

Uh oh!

Conversation

iadmytro commented Sep 15, 2022

Uh oh!

Uh oh!

Uh oh!

AngelCastilloB left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iccicci commented Sep 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mirceahasegan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mkazlauskas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iccicci commented Sep 27, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AngelCastilloB left a comment

Choose a reason for hiding this comment

Uh oh!

rhyslbw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

iccicci commented Sep 21, 2022 •

edited

Loading