refactor(core): do not add some undefined keys in deserialization

Some deserialization functions add some keys with undefined value.
The DbSyncChainHistoryProvider has a slightly different behavior not adding those keys.
In order to unify the output of BlockfrostChainHistoryProvider (which deserializes
transactions CBOR) with the one from DbSyncChainHistoryProvider these keys
are no longer added from deserialization as well.

Author: iccicci

packages/core/src/Serialization/AuxiliaryData/AuxiliaryData.ts

@@ -228,10 +228,13 @@ export class AuxiliaryData {
    */
   toCore(): Cardano.AuxiliaryData {
     const scripts = this.#getCoreScripts();
-    return {
-      blob: this.#metadata ? this.#metadata.toCore() : undefined,
-      scripts: scripts.length > 0 ? scripts : undefined
+    const auxiliaryData: Cardano.AuxiliaryData = {
+      blob: this.#metadata ? this.#metadata.toCore() : undefined
     };
+
+    if (scripts.length > 0) auxiliaryData.scripts = scripts;
+
+    return auxiliaryData;
   }
 
   /**

packages/core/src/Serialization/Certificates/PoolParams/PoolParams.ts

@@ -194,11 +194,10 @@ export class PoolParams {
   toCore(): Cardano.PoolParameters {
     const rewardAccountAddress = this.#rewardAccount.toAddress();
 
-    return {
+    const poolParams: Cardano.PoolParameters = {
       cost: this.#cost,
       id: PoolId.fromKeyHash(this.#operator),
       margin: this.#margin.toCore(),
-      metadataJson: this.#poolMetadata?.toCore(),
       owners: this.#poolOwners
         .toCore()
         .map((keyHash) => createRewardAccount(keyHash, rewardAccountAddress.getNetworkId())),
@@ -207,6 +206,10 @@ export class PoolParams {
       rewardAccount: this.#rewardAccount.toAddress().toBech32() as Cardano.RewardAccount,
       vrf: this.#vrfKeyHash
     };
+
+    if (this.#poolMetadata) poolParams.metadataJson = this.#poolMetadata.toCore();
+
+    return poolParams;
   }
 
   /**

packages/core/src/Serialization/Transaction.ts

@@ -122,13 +122,18 @@ export class Transaction {
    * @returns The Core Tx object.
    */
   toCore(): Cardano.Tx {
-    return {
-      auxiliaryData: this.#auxiliaryData ? this.#auxiliaryData.toCore() : undefined,
+    const tx: Cardano.Tx = {
       body: this.#body.toCore(),
       id: this.getId(),
       isValid: this.#isValid,
       witness: this.#witnessSet.toCore()
     };
+
+    if (this.#auxiliaryData) {
+      tx.auxiliaryData = this.#auxiliaryData.toCore();
+    }
+
+    return tx;
   }
 
   /**

packages/core/src/Serialization/TransactionBody/TransactionOutput.ts

@@ -208,16 +208,21 @@ export class TransactionOutput {
    * @returns The Core TransactionOutput object.
    */
   toCore(): Cardano.TxOut {
-    return {
+    const value = this.#amount.toCore();
+    if (!value.assets) delete value.assets;
+
+    const txOut: Cardano.TxOut = {
       address: this.#address.asByron()
         ? this.#address.toBase58()
         : (this.#address.toBech32() as unknown as Cardano.PaymentAddress),
-      datum:
-        this.#datum && this.#datum.kind() === DatumKind.InlineData ? this.#datum.asInlineData()?.toCore() : undefined,
-      datumHash: this.#datum && this.#datum.kind() === DatumKind.DataHash ? this.#datum.asDataHash() : undefined,
-      scriptReference: this.#scriptRef ? this.#scriptRef.toCore() : undefined,
-      value: this.#amount.toCore()
+      value
     };
+
+    if (this.#datum && this.#datum.kind() === DatumKind.InlineData) txOut.datum = this.#datum.asInlineData()?.toCore();
+    if (this.#datum && this.#datum.kind() === DatumKind.DataHash) txOut.datumHash = this.#datum.asDataHash();
+    if (this.#scriptRef) txOut.scriptReference = this.#scriptRef.toCore();
+
+    return txOut;
   }
 
   /**

packages/core/src/Serialization/Update/ProtocolParamUpdate.ts

@@ -412,17 +412,15 @@ export class ProtocolParamUpdate {
    * @returns The Core ProtocolParamUpdate object.
    */
   toCore(): Cardano.ProtocolParametersUpdate {
-    return {
+    const protocolParametersUpdate: Cardano.ProtocolParametersUpdate = {
       coinsPerUtxoByte: this.#adaPerUtxoByte ? Number(this.#adaPerUtxoByte) : undefined,
       collateralPercentage: this.#collateralPercentage,
       committeeTermLimit: this.#committeeTermLimit ? EpochNo(this.#committeeTermLimit) : undefined,
       costModels: this.#costModels?.toCore(),
       dRepDeposit: this.#drepDeposit,
       dRepInactivityPeriod: this.#drepInactivityPeriod ? EpochNo(this.#drepInactivityPeriod) : undefined,
       dRepVotingThresholds: this.#drepVotingThresholds?.toCore(),
-      decentralizationParameter: this.#d ? this.#d.toFloat().toString() : undefined,
       desiredNumberOfPools: this.#nOpt,
-      extraEntropy: this.#extraEntropy,
       governanceActionDeposit: this.#governanceActionDeposit,
       governanceActionValidityPeriod: this.#governanceActionValidityPeriod
         ? EpochNo(this.#governanceActionValidityPeriod)
@@ -447,10 +445,15 @@ export class ProtocolParamUpdate {
       poolRetirementEpochBound: this.#maxEpoch,
       poolVotingThresholds: this.#poolVotingThresholds?.toCore(),
       prices: this.#executionCosts?.toCore(),
-      protocolVersion: this.#protocolVersion?.toCore(),
       stakeKeyDeposit: this.#keyDeposit ? Number(this.#keyDeposit) : undefined,
       treasuryExpansion: this.#treasuryGrowthRate ? this.#treasuryGrowthRate.toFloat().toString() : undefined
     };
+
+    if (this.#d) protocolParametersUpdate.decentralizationParameter = this.#d.toFloat().toString();
+    if (this.#extraEntropy !== undefined) protocolParametersUpdate.extraEntropy = this.#extraEntropy;
+    if (this.#protocolVersion) protocolParametersUpdate.protocolVersion = this.#protocolVersion.toCore();
+
+    return protocolParametersUpdate;
   }
 
   /**