refactor: reduce dependencies of query crate
#172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we need the full `datafusion` department for testing, we only need `datafusion-execution` for the actual compilation of the `query` crate. This somewhat speeds up the compilation of downstream consumers like InfluxDB since they don't need to wait for `datafusion` to be compiled before they can compile `query` (that's automatically handled by cargo).
crepererum
force-pushed
the
crepererum/df-exec-dep
branch
from
0f2d085 to
4fbf022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we need the full
datafusiondepartment for testing, we only needdatafusion-executionfor the actual compilation of thequerycrate. This somewhat speeds up the compilation of downstream consumers like InfluxDB since they don't need to wait fordatafusionto be compiled before they can compilequery(that's automatically handled by cargo).