Skip to content

Commit e765680

Browse files
authored
Add lint unchecked and deprecated warnings to compiler config (#94)
Signed-off-by: Pavol Loffay <[email protected]>
1 parent ecc754f commit e765680

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

build.gradle.kts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ allprojects {
1111
sourceCompatibility = JavaVersion.VERSION_1_8
1212
targetCompatibility = JavaVersion.VERSION_1_8
1313
}
14+
15+
tasks.withType<JavaCompile> {
16+
options.compilerArgs.add("-Xlint:unchecked")
17+
options.isDeprecation = true
18+
}
1419
}
1520

1621
val testDependencies by configurations.creating {

instrumentation/grpc-1.5/src/main/java/io/opentelemetry/instrumentation/hypertrace/grpc/v1_5/GrpcSpanDecorator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public static void addMetadataAttributes(
7171
}
7272

7373
public static Map<String, String> metadataToMap(Metadata metadata) {
74-
Map<String, String> mapHeaders = new LinkedHashMap(metadata.keys().size());
74+
Map<String, String> mapHeaders = new LinkedHashMap<>(metadata.keys().size());
7575
for (String key : metadata.keys()) {
7676
if (key.endsWith(Metadata.BINARY_HEADER_SUFFIX)) {
7777
continue;

instrumentation/grpc-1.5/src/main/java/io/opentelemetry/instrumentation/hypertrace/grpc/v1_5/server/GrpcServerInterceptor.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ public <ReqT, RespT> ServerCall.Listener<ReqT> interceptCall(
5656
FilterProvider.getFilterEvaluator().evaluateRequestHeaders(currentSpan, mapHeaders);
5757
if (filterResult.blockExecution()) {
5858
call.close(Status.PERMISSION_DENIED, new Metadata());
59-
return NoopServerCallListener.INSTANCE;
59+
@SuppressWarnings("unchecked")
60+
ServerCall.Listener<ReqT> noop = NoopServerCallListener.INSTANCE;
61+
return noop;
6062
}
6163

6264
Listener<ReqT> serverCall = next.startCall(new TracingServerCall<>(call, currentSpan), headers);

instrumentation/servlet/servlet-2.3/src/main/java/io/opentelemetry/instrumentation/hypertrace/servlet/v2_3/Servlet2BodyInstrumentation.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ public static Object start(
159159
ServletSpanDecorator.addSessionId(currentSpan, httpRequest);
160160

161161
// set request headers
162+
@SuppressWarnings("unchecked")
162163
Enumeration<String> headerNames = httpRequest.getHeaderNames();
163164
Map<String, String> headers = new HashMap<>();
164165
while (headerNames.hasMoreElements()) {

0 commit comments

Comments
 (0)