Fix #1131 - Have Global (Grabber) settings reflected correctly in non-default instances #1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y read by non-default instances
|
Hello @Lord-Grey 👋 I'm your friendly neighborhood bot and would like to say thank you for So that you and other users can test your changes more quickly, If you make changes to your PR, i create a new link to your workflow artifacts. Best regards, |
tpmodding
approved these changes
Feb 11, 2021
Paulchen-Panther
approved these changes
Feb 11, 2021
Closed
14 tasks
14 tasks
Lord-Grey
added a commit
that referenced
this pull request
Feb 17, 2021
EliteScientist
pushed a commit
to EliteScientist/hyperion.ng
that referenced
this pull request
Dec 24, 2022
…y read by non-default instances (hyperion-project#1186)
EliteScientist
pushed a commit
to EliteScientist/hyperion.ng
that referenced
this pull request
Dec 24, 2022
…1188) * Handle Arrays & Objects differently * Fix UI error, if "last instance used" does not longer exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Configuration is now read from database which takes care of global and instance specific configurations, rather than using an instance's cache.
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
Fixes #1131