Precalculate isIdentity in OkhsvTransform

Author: xkns

include/utils/OkhsvTransform.h

@@ -48,6 +48,13 @@ class OkhsvTransform
 	void transform(uint8_t & red, uint8_t & green, uint8_t & blue);
 
 private:
+	/// Sets _isIdentity to true if both gain values are at their neutral setting
+	void updateIsIdentity();
+
+	/// Gain settings
 	float _saturationGain
 		, _valueGain;
+
+	/// Is true if the gain settings result in an identity transformation
+	bool _isIdentity;
 };

libsrc/utils/OkhsvTransform.cpp

@@ -13,12 +13,14 @@ OkhsvTransform::OkhsvTransform()
 {
 	_saturationGain = 1.0;
 	_valueGain = 1.0;
+	_isIdentity = true;
 }
 
 OkhsvTransform::OkhsvTransform(float saturationGain, float valueGain)
 {
 	_saturationGain = saturationGain;
 	_valueGain = valueGain;
+	updateIsIdentity();
 }
 
 float OkhsvTransform::getSaturationGain() const
@@ -29,6 +31,7 @@ float OkhsvTransform::getSaturationGain() const
 void OkhsvTransform::setSaturationGain(float saturationGain)
 {
 	_saturationGain = saturationGain;
+	updateIsIdentity();
 }
 
 float OkhsvTransform::getValueGain() const
@@ -39,11 +42,12 @@ float OkhsvTransform::getValueGain() const
 void OkhsvTransform::setValueGain(float valueGain)
 {
 	_valueGain = valueGain;
+	updateIsIdentity();
 }
 
 bool OkhsvTransform::isIdentity() const
 {
-	return getSaturationGain() == 1.0f && getValueGain() == 1.0f;
+	return _isIdentity;
 }
 
 void OkhsvTransform::transform(uint8_t & red, uint8_t & green, uint8_t & blue)
@@ -58,3 +62,8 @@ void OkhsvTransform::transform(uint8_t & red, uint8_t & green, uint8_t & blue)
 
 	ColorSys::okhsv2rgb(hue, saturation, value, red, green, blue);
 }
+
+void OkhsvTransform::updateIsIdentity()
+{
+	_isIdentity = _saturationGain == 1.f && _valueGain == 1.5;
+}