Add options to either ignore or remove unknown migrations #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
force-pushed
the
remove-unregistered-migrations
branch
from
54fe2b3 to
1f135a2
Compare
adam-fowler
force-pushed
the
remove-unregistered-migrations
branch
from
f0401c1 to
14601cc
Compare
Joannis
reviewed
Oct 20, 2025
Comment on lines
70
to
77
| public struct ApplyOptions: OptionSet, Sendable { | ||
| public let rawValue: Int | ||
|
|
||
| public init(rawValue: Int) { self.rawValue = rawValue } | ||
|
|
||
| /// If database has a migration applied we don't know about, ignore it | ||
| static var ignoreUnknownMigrations: Self { .init(rawValue: 1 << 0) } | ||
| } |
Member
There was a problem hiding this comment.
Can we make this not backed by a raw value? I think we'll want to consider options that are not a single flag/boolean, but with an associatedvalue
Member
Author
There was a problem hiding this comment.
If we are to use OptionSet, it conforms to RawRepresentable
Comment on lines
174
to
183
| public struct RevertOptions: OptionSet, Sendable { | ||
| public let rawValue: Int | ||
|
|
||
| public init(rawValue: Int) { self.rawValue = rawValue } | ||
|
|
||
| /// Ignore migrations we don't know about | ||
| static var ignoreUnknownMigrations: Self { .init(rawValue: 1 << 0) } | ||
| /// Remove database entry for migrations we don't know about | ||
| static var removeUnknownMigrations: Self { .init(rawValue: 1 << 1) } | ||
| } |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 4 4
Lines 450 450
=======================================
Hits 415 415
Misses 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Joannis
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new options parameter to
apply,revertandrevertInconsistent.applyhas option.ignoreUnknownMigrationsreverthas options.ignoreUnknownMigrationsand.removeUnknownMigrationsrevertInconsistenthas options.ignoreUnknownMigrationsand.removeUnknownMigrationsAlso added
Migrations.add(_:skipDuplicates:)which takessome Collection<any DatabaseMigration>