Skip to content

Conversation

@fabxoe
Copy link
Contributor

@fabxoe fabxoe commented Sep 19, 2024

What does this PR do?

Translated the main_classes/onnx.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@chhaewxn, @ahnjj, @jun048098, @fabxoe, @nuatmochoi, @heuristicwave

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?


## ONNX 특징[[onnx-features]]

각 ONNX 설정은 다양한 유형의 토폴로지나 작업에 대해 모델을 내보낼 수 있게 해주는 _features_ 세트와 연관되어 있습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
각 ONNX 설정은 다양한 유형의 토폴로지나 작업에 대해 모델을 내보낼 수 있게 해주는 _features_ 세트와 연관되어 있습니다.
각 ONNX 설정은 다양한 유형의 토폴로지나 작업의 모델을 익스포트 해주는 _features_ 세트와 관련이 있습니다.

export가 glossary에 안올라와 있어서, 임의로 익스포트로 바꿔보았습니다!


## ONNX 설정[[onnx-configurations]]

내보내고자 하는 모델 아키텍처의 유형에 따라 상속받아야 할 세 가지 추상 클래스를 제공합니다:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
내보내고자 하는 모델 아키텍처의 유형에 따라 상속받아야 할 세 가지 추상 클래스를 제공합니다:
익스포트하고자하는 모델 아키텍처 유형에 따라 상속받아야 할 세 가지 추상 클래스를 제공합니다:

Copy link
Contributor

@nuatmochoi nuatmochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 트랜스포머 문서에서는 Transformers를 따로 번역하지 않았던 것으로 기억해서 수정해보았습니다.


# 🤗 트랜스포머 모델을 ONNX로 내보내기[[exporting--transformers-models-to-onnx]]

🤗 트랜스포머는 `transformers.onnx` 패키지를 제공하며, 패키지를 통해 설정 객체를 활용함으로써 모델 체크포인트를 ONNX 그래프로 변환할 수 있게 합니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
🤗 트랜스포머는 `transformers.onnx` 패키지를 제공하며, 패키지를 통해 설정 객체를 활용함으로써 모델 체크포인트를 ONNX 그래프로 변환할 수 있게 합니다.
🤗 Transformers는 `transformers.onnx` 패키지를 제공하며, 패키지를 통해 설정 객체를 활용함으로써 모델 체크포인트를 ONNX 그래프로 변환할 수 있게 합니다.

@fabxoe fabxoe marked this pull request as ready for review October 7, 2024 02:28
Co-authored-by: Ahnjj_DEV <[email protected]>
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@stevhliu stevhliu merged commit 386401e into huggingface:main Oct 9, 2024
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
…33601)

* docs: ko: main_classes/onnx.md

* feat: nmt draft

* fix: resolve suggestions

Co-authored-by: Ahnjj_DEV <[email protected]>

* fix: resolve suggestions

* fix: resolve suggestions

* fix: resolve suggestions

Co-authored-by: SeongWooChoi <[email protected]>

* fix: resolve suggestions

Co-authored-by: SeongWooChoi <[email protected]>

* fix: resolve suggestions

Co-authored-by: Ahnjj_DEV <[email protected]>

---------

Co-authored-by: Ahnjj_DEV <[email protected]>
Co-authored-by: SeongWooChoi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants