Richer conversational snippet for AutoModel #1611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcuenca
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c and
ngxson
as code owners
julien-c
reviewed
Jul 11, 2025
|
I wanted to start the discussion because longer snippets could perhaps start making sense now that we auto-create notebooks, but happy to defer for now. |
|
that's fine we can always try imo! let's see what others think too |
Vaibhavs10
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
LGTM and thanks! my only worry is that it makes the overall snippet dialog a bit too huge, maybe we can collapse the AutoModel snippet by default on UI. WDYT @julien-c @gary149
Makes sense to start conservative with image-text-to-text and text-generation to begin with and the logic looks good to me too.
Otherwise let's merge and see how the users react to it!
gary149
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't remember if we already discussed about this. This is an attempt to make the
AutoModelsnippet more self-contained, for the particular but frequent case of conversational transformers models. The pipeline version already got this treatment in #1434, but theAutoModelversion is currently too barebones in comparison, as shown in the screenshot below.In my opinion this could reduce the friction for users that want to experiment with the models in Colab or Kaggle.
cc @Vaibhavs10 @ariG23498