[Tests] Run slow matrix sequentially #3500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Doesn't seem the cause. Running the tests inside the docker container it looks like a portion of memory is not being freed up and it accumulates. Running outside the container I don't see the same problem but |
|
Running tests with |
|
@pcuenca feel free to merge if it helps |
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
[tests] Run slow matrix sequentially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a suspicion, feel free to close.
Both "Slow PyTorch CUDA tests on Ubuntu" and "Slow ONNXRuntime CUDA tests on Ubuntu" use the same runner (
docker-gpu), and there is 1 machine configured to run those tests. My understanding is that the CI environment will run tests in a matrix in parallel by default, which could be the reason for the weird oom issues.If this is actually the case, we could maybe reorganize the tests differently so that the "Slow Flax TPU tests", which use a different runner, run in parallel with any of these.