[docs] Clarify purpose of reproducibility docs #2756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevhliu
requested review from
pcuenca,
yiyixuxu,
sayakpaul and
patrickvonplaten
|
The documentation is not available anymore as the PR was closed or merged. |
patrickvonplaten
approved these changes
Mar 21, 2023
pcuenca
approved these changes
Mar 21, 2023
w4ffl35
pushed a commit
to w4ffl35/diffusers
that referenced
this pull request
Apr 14, 2023
* clarify purpose of repro docs * apply feedback
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* clarify purpose of repro docs * apply feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a quick glance, it seems like the Reusing seeds for deterministic generation and Reproducibility docs are talking about using the same functionality, setting a seed to reproduce results. However, the purposes of these docs are very different. The former is focused on how to improve an image, while the latter is more about testing. This PR clarifies the purpose of these two docs so it's clear what users can expect, and why they should read one versus the other.