misc fixes #2282
Merged
misc fixes #2282
+44
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamberman
commented
Feb 8, 2023
| @@ -65,7 +68,7 @@ | |||
| type=str, | |||
| help=( | |||
| "The prediction type that the model was trained on. Use 'epsilon' for Stable Diffusion v1.X and Stable" | |||
| " Siffusion v2 Base. Use 'v-prediction' for Stable Diffusion v2." | |||
| " Diffusion v2 Base. Use 'v_prediction' for Stable Diffusion v2." | |||
There was a problem hiding this comment.
The scheduler takes 'v_prediction'
williamberman
commented
Feb 8, 2023
|
|
||
| from ...configuration_utils import ConfigMixin, register_to_config | ||
| from ...schedulers.scheduling_utils import SchedulerMixin | ||
|
|
||
|
|
||
| warnings.filterwarnings("ignore") |
There was a problem hiding this comment.
This warning filter will apply globally because this module ends up being imported at diffusers/__init__.py
|
The documentation is not available anymore as the PR was closed or merged. |
williamberman
commented
Feb 8, 2023
Comment on lines
+826
to
+827
| if prediction_type == "v-prediction": | ||
| prediction_type = "v_prediction" |
There was a problem hiding this comment.
Just in case because of previous script docs
williamberman
commented
Feb 8, 2023
| @@ -305,7 +305,6 @@ def step( | |||
| prev_sample = alpha_prod_t_prev ** (0.5) * pred_original_sample + pred_sample_direction | |||
|
|
|||
| if eta > 0: | |||
| # randn_like does not support generator https://github.com/pytorch/pytorch/issues/27072 | |||
There was a problem hiding this comment.
left over comment before we switched to rand_tensor
williamberman
commented
Feb 8, 2023
Comment on lines
+30
to
+39
| if "DIFFUSERS_TEST_DEVICE" in os.environ: | ||
| torch_device = os.environ["DIFFUSERS_TEST_DEVICE"] | ||
|
|
||
| if is_torch_higher_equal_than_1_12: | ||
| # Some builds of torch 1.12 don't have the mps backend registered. See #892 for more details | ||
| mps_backend_registered = hasattr(torch.backends, "mps") | ||
| torch_device = "mps" if (mps_backend_registered and torch.backends.mps.is_available()) else torch_device | ||
| available_backends = ["cuda", "cpu", "mps"] | ||
| if torch_device not in available_backends: | ||
| raise ValueError( | ||
| f"unknown torch backend for diffusers tests: {torch_device}. Available backends are:" | ||
| f" {available_backends}" | ||
| ) | ||
| logger.info(f"torch_device overrode to {torch_device}") |
There was a problem hiding this comment.
It can be helpful to force the tests to run on a particular device -- i.e. I use this snippet when I want to force the tests to run on the cpu when I'm using a macbook or a machine with cuda
williamberman
requested review from
patrickvonplaten,
yiyixuxu,
pcuenca and
patil-suraj
patil-suraj
approved these changes
Feb 8, 2023
| @@ -65,7 +68,7 @@ | |||
| type=str, | |||
| help=( | |||
| "The prediction type that the model was trained on. Use 'epsilon' for Stable Diffusion v1.X and Stable" | |||
| " Siffusion v2 Base. Use 'v-prediction' for Stable Diffusion v2." | |||
| " Diffusion v2 Base. Use 'v_prediction' for Stable Diffusion v2." | |||
Comment on lines
+30
to
+39
| if "DIFFUSERS_TEST_DEVICE" in os.environ: | ||
| torch_device = os.environ["DIFFUSERS_TEST_DEVICE"] | ||
|
|
||
| if is_torch_higher_equal_than_1_12: | ||
| # Some builds of torch 1.12 don't have the mps backend registered. See #892 for more details | ||
| mps_backend_registered = hasattr(torch.backends, "mps") | ||
| torch_device = "mps" if (mps_backend_registered and torch.backends.mps.is_available()) else torch_device | ||
| available_backends = ["cuda", "cpu", "mps"] | ||
| if torch_device not in available_backends: | ||
| raise ValueError( | ||
| f"unknown torch backend for diffusers tests: {torch_device}. Available backends are:" | ||
| f" {available_backends}" | ||
| ) | ||
| logger.info(f"torch_device overrode to {torch_device}") |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
Co-authored-by: Patrick von Platen <[email protected]>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
Co-authored-by: Patrick von Platen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few misc fixes :)