Skip to content

Inconsistent random transform between source and target image in train_instruct_pix2pix #10697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Luvata opened this issue Jan 31, 2025 · 0 comments · Fixed by #10698
Closed
Labels
bug Something isn't working

Comments

@Luvata
Copy link
Contributor

Luvata commented Jan 31, 2025

Describe the bug

Currently, random cropping and random flipping in train_transform of train_instruct_pix2pix.py and train_instruct_pix2pix_sdxl.py are applied independently to the source and target images, which leads to discrepancies.

This inconsistency can cause misalignment between the source and target images (the source could be flipped but not the target, or vice versa)

Reproduction

Following InstructPix2Pix training example, but set resolution to 512 to turn off random cropping. My edit model tends to return symmetric images.

Logs

System Info

0.33.0.dev0

Who can help?

@sayakpaul

@Luvata Luvata added the bug Something isn't working label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant