From c97a50364e5e4dd8b2f3d6caca50f817ec50dabf Mon Sep 17 00:00:00 2001 From: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com> Date: Tue, 11 Apr 2023 10:48:34 +0200 Subject: [PATCH 1/2] Pass clobber True --- tests/fixtures/fsspec.py | 4 ++-- tests/test_streaming_download_manager.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/fixtures/fsspec.py b/tests/fixtures/fsspec.py index 8aaa181a77e..32f23d4e723 100644 --- a/tests/fixtures/fsspec.py +++ b/tests/fixtures/fsspec.py @@ -93,8 +93,8 @@ def _strip_protocol(cls, path): @pytest.fixture def mock_fsspec(): original_registry = fsspec.registry.copy() - fsspec.register_implementation("mock", MockFileSystem) - fsspec.register_implementation("tmp", TmpDirFileSystem) + fsspec.register_implementation("mock", MockFileSystem, clobber=True) + fsspec.register_implementation("tmp", TmpDirFileSystem, clobber=True) yield fsspec.registry = original_registry diff --git a/tests/test_streaming_download_manager.py b/tests/test_streaming_download_manager.py index ae4335cbbb1..c33e6c0bbbd 100644 --- a/tests/test_streaming_download_manager.py +++ b/tests/test_streaming_download_manager.py @@ -131,7 +131,7 @@ def _open( @pytest.fixture def mock_fsspec(): original_registry = fsspec.registry.copy() - fsspec.register_implementation("mock", DummyTestFS) + fsspec.register_implementation("mock", DummyTestFS, clobber=True) yield fsspec.registry = original_registry From fda7ed32450f2368b1e443109caa0fb51d1aad43 Mon Sep 17 00:00:00 2001 From: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com> Date: Tue, 11 Apr 2023 10:53:43 +0200 Subject: [PATCH 2/2] Unpin fsspec --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index e16185f174a..66f316afa15 100644 --- a/setup.py +++ b/setup.py @@ -128,7 +128,7 @@ "importlib_metadata;python_version<'3.8'", # to save datasets locally or on any filesystem # minimum 2021.11.1 so that BlockSizeError is fixed: see https://github.com/fsspec/filesystem_spec/pull/830 - "fsspec[http]>=2021.11.1,<2023.4.0", # Temporary pin + "fsspec[http]>=2021.11.1", # for data streaming via http "aiohttp", # To get datasets from the Datasets Hub on huggingface.co