Requests with proxied domain names in query arguments route unexpectedly

[danielfay]

Hello,

I'm having an issue with my proxy properly routing when a domain earlier in the proxy (such as myothersite.ca) is present in the query arguments of a later site.

The structure of the proxy file looks like this:

var httpProxy = require('http-proxy');

var options = {
  router: {
    'myothersite.ca': '127.0.0.1:9003',
    'example2.mysite.ca': '127.0.0.1:9002',
    'example.mysite.ca': '127.0.0.1:9001',
    'mysite.ca': '127.0.0.1:9000'
  }
};

// main reverse-proxy router
var proxyServer = httpProxy.createServer(options);
proxyServer.listen(80);

With the example above the following cases won't route correctly:

• http://mysite.ca/?email=example@myothersite.ca
  • This will route to myothersite.ca
• http://example.mysite.ca/?refer_url=example2.mysite.ca
  • This will route to example2.mysite.ca

But the following will route correctly:

• http://myothersite.ca/?email=example@mysite.ca
  • This will route to myothersite.ca
• http://example2.mysite.ca/?refer_url=example.mysite.ca
  • This will route to example2.mysite.ca

Can someone point me at the lines that do this parsing? It should be a straight forward fix after that.

[buschtoens]

Here you go: https://github.com/nodejitsu/node-http-proxy/blob/master/lib/node-http-proxy/proxy-table.js#L117
This behaviour isn't really a bug. By default http-proxy checks for hostname and path, where the path check is more important than the host check. This is why your URLs get routed to the "wrong" host.

A quick "fix" for now would be to do this:

var httpProxy = require('http-proxy');

var options = {
  hostnameOnly: true, // this tells http-proxy to ignore the path
  router: {
    'myothersite.ca': '127.0.0.1:9003',
    'example2.mysite.ca': '127.0.0.1:9002',
    'example.mysite.ca': '127.0.0.1:9001',
    'mysite.ca': '127.0.0.1:9000'
  }
};

// main reverse-proxy router
var proxyServer = httpProxy.createServer(options);
proxyServer.listen(80);

This is more of a design flaw. Most users would only want to do some host routing. hostnameOnly should be true by default.

[coderarity]

The keys are converted to a regular expression, so use that to your advantage. Maybe add a $ at the beginning of your router keys?

We have to match the routes in some order. It's going from beginning to end and using the first route that matches. I think this is fine.

[danielfay]

@silvinci Sorry my example was a little misleading. I have hostnameOnly off for a reason. I also use the proxy to route to a static-file server. Thanks though.

@coderarity Appending '^' to the beginning of the keys solves my issue. Thanks for the hint - I have a better idea of how http-proxy operates now, which has helped me simplify much of the routing list.

Might as well update the initial example to reflect my new proxy:

var httpProxy = require('http-proxy');

var options = {
  router: {
    '^(www.)?myothersite.ca': '127.0.0.1:9003',
    '^example2.mysite.ca': '127.0.0.1:9002',
    '^example.mysite.ca': '127.0.0.1:9001',
    '^(www.)?mysite.ca': '127.0.0.1:9000'
  }
};

// main reverse-proxy router
var proxyServer = httpProxy.createServer(options);
proxyServer.listen(80);