Skip to content

Commit 5befcb1

Browse files
committed
fix(js/ts) constants may include numbers
1 parent ca331e9 commit 5befcb1

File tree

5 files changed

+17
-2
lines changed

5 files changed

+17
-2
lines changed

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Grammars:
1515
- fix(elixir) fixed number detection when numbers start with a zero (#3212) [Angelika Tyborska][]
1616
- fix(ps1) Flag highlighted incorrectly (#3167) [Pankaj Patil][]
1717
- fix(latex) Allow wider syntax for magic comments (#3243) [Benedikt Wilde][]
18+
- fix(js/ts) Constants may include numbers [Josh Goebel][]
1819

1920
[Stel Abrego]: https://github.com/stelcodes
2021
[Josh Goebel]: https://github.com/joshgoebel

src/languages/javascript.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ export default function(hljs) {
299299

300300
const UPPER_CASE_CONSTANT = {
301301
relevance: 0,
302-
match: /\b[A-Z][A-Z_]+\b/,
302+
match: /\b[A-Z][A-Z_0-9]+\b/,
303303
className: "variable.constant"
304304
};
305305

test/markup/csharp/try-catch.expect.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
<span class="hljs-keyword">catch</span> (InvalidCastException e) <span class="hljs-keyword">when</span> (e.Data != <span class="hljs-literal">null</span>)
66
{
77
<span class="hljs-keyword">throw</span>;
8-
}
8+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<span class="hljs-keyword">const</span> <span class="hljs-variable constant_">KEY_KPASTERISK</span> = <span class="hljs-number">55</span>;
2+
<span class="hljs-keyword">const</span> <span class="hljs-variable constant_">KEY_KP7</span> = <span class="hljs-number">71</span>;
3+
<span class="hljs-keyword">const</span> <span class="hljs-variable constant_">KEY_KP8</span> = <span class="hljs-number">72</span>;
4+
5+
<span class="hljs-keyword">if</span> (key == <span class="hljs-variable constant_">KEY_KP8</span>) {
6+
<span class="hljs-comment">// do stuff</span>
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
const KEY_KPASTERISK = 55;
2+
const KEY_KP7 = 71;
3+
const KEY_KP8 = 72;
4+
5+
if (key == KEY_KP8) {
6+
// do stuff
7+
}

0 commit comments

Comments
 (0)