Merge pull request #1 from hewittk/new-boundary-inputs

New boundary inputs

Author: hewittk

pandas/core/arrays/datetimelike.py

@@ -1830,13 +1830,16 @@ def validate_endpoints(closed):
     left_closed = False
     right_closed = False
 
-    if closed is None:
+    if closed is None or closed == "True":
         left_closed = True
         right_closed = True
     elif closed == "left":
         left_closed = True
     elif closed == "right":
         right_closed = True
+    elif closed == "both" or closed == "False":
+        left_closed = False
+        right_closed = False
     else:
         raise ValueError("Closed has to be either 'left', 'right' or None")
 

pandas/core/series.py

@@ -4670,7 +4670,7 @@ def isin(self, values) -> Series:
             self, method="isin"
         )
 
-    def between(self, left, right, inclusive=True) -> Series:
+    def between(self, left, right, inclusive="True") -> Series:
         """
         Return boolean Series equivalent to left <= series <= right.
 
@@ -4684,7 +4684,8 @@ def between(self, left, right, inclusive=True) -> Series:
             Left boundary.
         right : scalar or list-like
             Right boundary.
-        inclusive : bool, default True
+        inclusive : str, default "True"
+
             Include boundaries.
 
         Returns
@@ -4736,12 +4737,21 @@ def between(self, left, right, inclusive=True) -> Series:
         3    False
         dtype: bool
         """
-        if inclusive:
+
+        if inclusive == "True" or inclusive == "both":
             lmask = self >= left
             rmask = self <= right
-        else:
+        elif inclusive == "left":
+            lmask = self >= left
+            rmask = self < right
+        elif inclusive == "right":
+            lmask = self > left
+            rmask = self <= right
+        elif inclusive == "False":
             lmask = self > left
             rmask = self < right
+        else:
+            raise ValueError("String input of 'True', 'both' 'False' 'left', 'right', should be submitted")
 
         return lmask & rmask