Skip to content

Conversation

@sinclairpaul
Copy link
Member

@sinclairpaul sinclairpaul commented Jul 7, 2025

Proposed Changes

🔨 Update php memory limit to 256MB

Related Issues

Fixes #396

Summary by CodeRabbit

  • Chores
    • Increased PHP memory limit to 256M for improved performance.

@sinclairpaul sinclairpaul added the enhancement Enhancement of the code, not introducing new features. label Jul 7, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 7, 2025

Walkthrough

The PHP-FPM pool configuration was updated to explicitly set the memory_limit directive to 256M for the "www" pool. No other configuration parameters were changed, and no code or logic was modified outside of this configuration file.

Changes

File(s) Change Summary
bookstack/rootfs/etc/php83/php-fpm.d/www.conf Added php_admin_value[memory_limit] = 256M to set PHP memory limit for the pool

Sequence Diagram(s)

No sequence diagram generated as the change is a configuration update only.

Assessment against linked issues

Objective Addressed Explanation
Allow raising PHP memory_limit to 256MB to resolve gallery thumbnail creation failures (#396)

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes detected.

Poem

In the warren of code, a tweak was made,
PHP’s memory limit, now less afraid.
Thumbnails grow with room to spare,
No more errors, just images there!
A hop, a skip, a code delight—
Bookstack’s gallery shines so bright! 🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
bookstack/rootfs/etc/php83/php-fpm.d/www.conf (1)

13-14: Consider mirroring the new limit for CLI/cron consistency.

Only FPM requests now benefit from the higher limit; artisan/cron jobs that run via php CLI will still inherit the lower default (typically 128 M). If BookStack performs heavy CLI tasks (e.g., sitemap generation, queues), you may want to replicate the memory_limit = 256M in the CLI php.ini or bake it into the entrypoint (php -d memory_limit=256M …).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f46d7c4 and 59f7110.

📒 Files selected for processing (1)
  • bookstack/rootfs/etc/php83/php-fpm.d/www.conf (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: workflows / Build armv7
  • GitHub Check: workflows / Build amd64
  • GitHub Check: workflows / Build aarch64
🔇 Additional comments (1)
bookstack/rootfs/etc/php83/php-fpm.d/www.conf (1)

14-14: memory_limit addition looks good and resolves #396.

Setting the pool-specific memory_limit to 256M via php_admin_value should alleviate the OOM reports without affecting global PHP defaults.

@sinclairpaul sinclairpaul merged commit c8a6201 into hassio-addons:main Jul 7, 2025
12 checks passed
@sinclairpaul sinclairpaul deleted the memory_limit branch July 7, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement of the code, not introducing new features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to create gallery thumbnails due to system resource limits

1 participant