-
-
Notifications
You must be signed in to change notification settings - Fork 15
🔨 Update php memory limit to 256MB #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe PHP-FPM pool configuration was updated to explicitly set the Changes
Sequence Diagram(s)No sequence diagram generated as the change is a configuration update only. Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
bookstack/rootfs/etc/php83/php-fpm.d/www.conf (1)
13-14: Consider mirroring the new limit for CLI/cron consistency.Only FPM requests now benefit from the higher limit; artisan/cron jobs that run via
phpCLI will still inherit the lower default (typically 128 M). If BookStack performs heavy CLI tasks (e.g., sitemap generation, queues), you may want to replicate thememory_limit = 256Min the CLIphp.inior bake it into the entrypoint (php -d memory_limit=256M …).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bookstack/rootfs/etc/php83/php-fpm.d/www.conf(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: workflows / Build armv7
- GitHub Check: workflows / Build amd64
- GitHub Check: workflows / Build aarch64
🔇 Additional comments (1)
bookstack/rootfs/etc/php83/php-fpm.d/www.conf (1)
14-14:memory_limitaddition looks good and resolves #396.Setting the pool-specific
memory_limitto256Mviaphp_admin_valueshould alleviate the OOM reports without affecting global PHP defaults.
Proposed Changes
🔨 Update php memory limit to 256MB
Related Issues
Fixes #396
Summary by CodeRabbit