From babe12562aae33f36dbb2be24f727f40eaa9a470 Mon Sep 17 00:00:00 2001 From: Luke Lau Date: Wed, 2 Sep 2020 21:15:50 +0100 Subject: [PATCH 1/2] Add 8.10.2 to github actions build --- .github/workflows/build.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a66482c139..0395d8317a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -15,7 +15,7 @@ jobs: strategy: fail-fast: false matrix: - ghc: ['8.10.1', '8.8.4', '8.8.3', '8.8.2', '8.6.5', '8.6.4'] + ghc: ['8.10.2', '8.10.1', '8.8.4', '8.8.3', '8.8.2', '8.6.5', '8.6.4'] os: [ubuntu-latest, macOS-latest, windows-latest] exclude: - os: windows-latest @@ -29,7 +29,7 @@ jobs: - uses: actions/checkout@v2 with: submodules: true - - uses: bubba/setup-haskell@d8110230d + - uses: bubba/setup-haskell@7235984 with: ghc-version: ${{ matrix.ghc }} cabal-version: '3.2' @@ -94,11 +94,11 @@ jobs: path: ${{ steps.compress_server_binary.outputs.path }} - name: Build Wrapper - if: matrix.ghc == '8.10.1' + if: matrix.ghc == '8.10.2' run: cabal build exe:hls-wrapper -O2 $LINUX_CABAL_ARGS - name: Compress Wrapper Binary - if: matrix.ghc == '8.10.1' + if: matrix.ghc == '8.10.2' id: compress_wrapper_binary run: | HLS_WRAPPER_BUILD=$(find dist-newstyle \( -name 'hls-wrapper' -o -name 'hls-wrapper.exe' \) -type f) @@ -117,7 +117,7 @@ jobs: fi - name: Upload Wrapper - if: matrix.ghc == '8.10.1' + if: matrix.ghc == '8.10.2' uses: actions/upload-release-asset@v1.0.2 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -128,7 +128,7 @@ jobs: asset_content_type: ${{ steps.compress_wrapper_binary.outputs.content_type}} - uses: actions/upload-artifact@v2 - if: matrix.ghc == '8.10.1' + if: matrix.ghc == '8.10.2' with: name: haskell-language-server-wrapper-${{ runner.OS }}${{env.EXE_EXT}}.${{ steps.compress_wrapper_binary.outputs.extension }} path: ${{ steps.compress_wrapper_binary.outputs.path }} From 46502c884dc1d85368be2149b2348366e1c9a6b3 Mon Sep 17 00:00:00 2001 From: Luke Lau Date: Wed, 2 Sep 2020 21:59:22 +0100 Subject: [PATCH 2/2] Disable ghc-8.10.2 on windows due to linker path issue --- .github/workflows/build.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0395d8317a..e84d490c68 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -18,6 +18,8 @@ jobs: ghc: ['8.10.2', '8.10.1', '8.8.4', '8.8.3', '8.8.2', '8.6.5', '8.6.4'] os: [ubuntu-latest, macOS-latest, windows-latest] exclude: + - os: windows-latest + ghc: '8.10.2' # broken due to https://gitlab.haskell.org/ghc/ghc/-/issues/18550 - os: windows-latest ghc: '8.8.4' # also fails due to segfault :( - os: windows-latest @@ -94,11 +96,11 @@ jobs: path: ${{ steps.compress_server_binary.outputs.path }} - name: Build Wrapper - if: matrix.ghc == '8.10.2' + if: matrix.ghc == '8.10.1' run: cabal build exe:hls-wrapper -O2 $LINUX_CABAL_ARGS - name: Compress Wrapper Binary - if: matrix.ghc == '8.10.2' + if: matrix.ghc == '8.10.1' id: compress_wrapper_binary run: | HLS_WRAPPER_BUILD=$(find dist-newstyle \( -name 'hls-wrapper' -o -name 'hls-wrapper.exe' \) -type f) @@ -117,7 +119,7 @@ jobs: fi - name: Upload Wrapper - if: matrix.ghc == '8.10.2' + if: matrix.ghc == '8.10.1' uses: actions/upload-release-asset@v1.0.2 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -128,7 +130,7 @@ jobs: asset_content_type: ${{ steps.compress_wrapper_binary.outputs.content_type}} - uses: actions/upload-artifact@v2 - if: matrix.ghc == '8.10.2' + if: matrix.ghc == '8.10.1' with: name: haskell-language-server-wrapper-${{ runner.OS }}${{env.EXE_EXT}}.${{ steps.compress_wrapper_binary.outputs.extension }} path: ${{ steps.compress_wrapper_binary.outputs.path }}