Skip to content

Commit c57ccf0

Browse files
committed
Update documentation
1 parent 180b29c commit c57ccf0

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

plugins/hls-tactics-plugin/README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,8 @@ actions. These code actions are provided by GHC and make typechecking extremely
4141
slow in the presence of typed holes. Because Wingman relies so heavily on typed
4242
holes, these features are in great tension.
4343

44-
The solution: we just remove the hole-fit actions. They are mostly subsumed by
45-
Wingman, and usually make extremely unhelpful suggestions, such as `replace _
46-
with id _`. If you'd prefer to use these actions, you can get them back by
47-
disabling Wingman.
44+
The solution: we just remove the hole-fit actions. If you'd prefer to use these
45+
actions, you can get them back by compiling HLS without the Wingman plugin.
4846

4947

5048
## Editor Configuration

test/functional/FunctionalCodeAction.hs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ redundantImportTests = testGroup "redundant import code actions" [
400400

401401
typedHoleTests :: TestTree
402402
typedHoleTests = testGroup "typed hole code actions" [
403-
ignoreTestBecause "Wingman changes the result of this test and I don't know how to disable Wingman" $
403+
ignoreTestBecause "Wingman changes the result of this test when enabled" $
404404
testCase "works" $
405405
runSession hlsCommand fullCaps "test/testdata" $ do
406406
doc <- openDoc "TypedHoles.hs" "haskell"
@@ -421,7 +421,7 @@ typedHoleTests = testGroup "typed hole code actions" [
421421
, "foo x = maxBound"
422422
]
423423

424-
, ignoreTestBecause "Wingman changes the result of this test and I don't know how to disable Wingman" $
424+
, ignoreTestBecause "Wingman changes the result of this test when enabled" $
425425
testCase "shows more suggestions" $
426426
runSession hlsCommand fullCaps "test/testdata" $ do
427427
doc <- openDoc "TypedHoles2.hs" "haskell"

0 commit comments

Comments
 (0)