Skip to content

Commit a8c0888

Browse files
committed
Drop support for GHC 8.10
Per our support policy, we should now deprecated 8.10. We might not want to do this immediately, but this PR implements it. TODO: - Make sure CI is still all happy - Simplify a lot of bindings that can now just be re-exports
1 parent 90d17fe commit a8c0888

File tree

69 files changed

+61
-3213
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+61
-3213
lines changed

.github/workflows/bench.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
strategy:
4747
fail-fast: false
4848
matrix:
49-
ghc: ['8.10.7', '9.2.5']
49+
ghc: ['9.2.5', '9.4.3']
5050
os: [ubuntu-latest]
5151

5252
# This code is fitted to the strategy: assumes Linux is used ... etc,
@@ -104,7 +104,7 @@ jobs:
104104
strategy:
105105
fail-fast: false
106106
matrix:
107-
ghc: ['8.10.7', '9.2.5']
107+
ghc: ['9.2.5', '9.4.3']
108108
os: [ubuntu-latest]
109109
cabal: ['3.6']
110110
example: ['cabal', 'lsp-types']

.github/workflows/caching.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ jobs:
8787
, "9.2.5"
8888
, "9.2.4"
8989
, "9.0.2"
90-
, "8.10.7"
9190
]
9291
os: [ "ubuntu-latest"
9392
, "macOS-latest"
@@ -113,7 +112,7 @@ jobs:
113112
# Fetching from github cache is faster than doing it from hackage
114113
# Sources does not change per ghc and ghc version son only doing it
115114
# for one matrix job (it is arbitrary)
116-
- if: steps.compiled-deps.outputs.cache-hit != 'true' && runner.os == 'Linux' && matrix.ghc == '8.10.7'
115+
- if: steps.compiled-deps.outputs.cache-hit != 'true' && runner.os == 'Linux' && matrix.ghc == '9.2.5'
117116
name: Download sources
118117
run: |
119118
cabal $cabalBuild --only-download --enable-benchmarks --enable-tests
@@ -128,7 +127,7 @@ jobs:
128127
# We build ghcide with benchs and test enabled to include its dependencies in the cache
129128
# (including shake-bench)
130129
# Only for the same ghc and os used in the bench workflow, so we save cache space
131-
- if: steps.compiled-deps.outputs.cache-hit != 'true' && runner.os == 'Linux' && matrix.ghc == '8.10.7'
130+
- if: steps.compiled-deps.outputs.cache-hit != 'true' && runner.os == 'Linux' && matrix.ghc == '9.2.5'
132131
name: Build ghcide benchmark
133132
run: |
134133
cabal $cabalBuild ghcide --enable-benchmarks --enable-tests

.github/workflows/flags.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ jobs:
4444
strategy:
4545
fail-fast: true
4646
matrix:
47-
ghc: [ "9.2.5"
47+
ghc: [ "9.4.3"
48+
, "9.2.5"
4849
, "9.0.2"
49-
, "8.10.7"
5050
]
5151
os: [ "ubuntu-latest"
5252
]

.github/workflows/hackage.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ jobs:
4040
"hls-qualify-imported-names-plugin", "hls-code-range-plugin",
4141
"hls-cabal-fmt-plugin",
4242
"haskell-language-server"]
43-
ghc: [ "9.0.2"
44-
, "8.10.7"
43+
ghc: [ "9.2.5"
44+
, "9.0.2"
4545
]
4646
exclude:
4747
- ghc: "9.0.2"
@@ -136,7 +136,7 @@ jobs:
136136
cabal haddock --haddock-for-hackage
137137
138138
- name: "Upload package dist tarball"
139-
if: steps.get-hackage-version.outputs.exists != 'true' && matrix.ghc == '8.10.7'
139+
if: steps.get-hackage-version.outputs.exists != 'true' && matrix.ghc == '9.2.5'
140140
uses: actions/upload-artifact@v3
141141
with:
142142
name: ${{ matrix.package }}

.github/workflows/test.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ jobs:
6666
, "9.2.4"
6767
, "9.2.3"
6868
, "9.0.2"
69-
, "8.10.7"
7069
]
7170
os: [ "ubuntu-latest"
7271
, "macOS-latest"
@@ -94,9 +93,6 @@ jobs:
9493
- os: ubuntu-latest
9594
ghc: '9.0.2'
9695
test: true
97-
- os: ubuntu-latest
98-
ghc: '8.10.7'
99-
test: true
10096
- os: windows-latest
10197
ghc: '9.4.2'
10298
test: true
@@ -108,9 +104,6 @@ jobs:
108104
- os: windows-latest
109105
ghc: '9.0.2'
110106
test: true
111-
- os: windows-latest
112-
ghc: '8.10.7'
113-
test: true
114107

115108
steps:
116109
- uses: actions/checkout@v3
@@ -270,6 +263,7 @@ jobs:
270263
run: cabal test hls-explicit-record-fields-plugin --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-explicit-record-fields-plugin --test-options="$TEST_OPTS"
271264

272265
## version needs to be limited since the tests depend on cabal-fmt which only builds using specific ghc versions
266+
## FIXME: this is unsatisfiable!
273267
- if: matrix.test && matrix.ghc == '8.10.7'
274268
name: Test hls-cabal-fmt-plugin test suite
275269
run: cabal test hls-cabal-fmt-plugin --flag=isolateTests --test-options="$TEST_OPTS" || cabal test hls-cabal-fmt-plugin --flag=isolateTests --test-options="$TEST_OPTS" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-cabal-fmt-plugin --flag=isolateTests --test-options="$TEST_OPTS"

.gitlab/tar.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ source "$CI_PROJECT_DIR/.gitlab/setup.sh"
1010
case "${TARBALL_EXT}" in
1111
zip)
1212
TARBALL_PREFIX="haskell-language-server"
13-
HLS_VERSION="$("$CI_PROJECT_DIR/out/haskell-language-server-8.10.7" --numeric-version)"
13+
HLS_VERSION="$("$CI_PROJECT_DIR/out/haskell-language-server-9.2.5" --numeric-version)"
1414
cd out/
1515
zip "${TARBALL_PREFIX}-${HLS_VERSION}-${TARBALL_ARCHIVE_SUFFIX}.zip" haskell-language-server-*
1616
find . -type f ! -name '*.zip' -delete

docs/contributing/plugin-tutorial.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ And here is the gist of the algorithm:
3434

3535
## Setup
3636

37-
To get started, let’s fetch the HLS repo and build it. You need at least GHC 8.10 for this:
37+
To get started, let’s fetch the HLS repo and build it. You need at least GHC 9.0 for this:
3838

3939
```
4040
git clone --recursive http://github.com/haskell/haskell-language-server hls

docs/support/ghc-version-support.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Support status (see the support policy below for more details):
2626
| 9.2.(1,2) | [1.7.0.0](https://github.com/haskell/haskell-language-server/releases/tag/1.7.0.0) | deprecated |
2727
| 9.0.2 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
2828
| 9.0.1 | [1.6.1.0](https://github.com/haskell/haskell-language-server/releases/tag/1.6.1.0) | deprecated |
29-
| 8.10.7 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
29+
| 8.10.7 | [1.9.0.0](https://github.com/haskell/haskell-language-server/releases/tag/1.9.0.0) | deprecated |
3030
| 8.10.6 | [1.6.1.0](https://github.com/haskell/haskell-language-server/releases/tag/1.6.1.0) | deprecated |
3131
| 8.10.5 | [1.5.1](https://github.com/haskell/haskell-language-server/releases/tag/1.5.1) | deprecated |
3232
| 8.10.(4,3,2) | [1.4.0](https://github.com/haskell/haskell-language-server/releases/tag/1.4.0) | deprecated |

docs/troubleshooting.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ stack install haskell-language-server
185185
You also can leverage `ghcup compile hls`:
186186

187187
```bash
188-
ghcup compile hls -v 1.6.1.0 --ghc 8.10.7
188+
ghcup compile hls -v 1.9.0.0 --ghc 9.2.5
189189
```
190190

191191
### Preprocessors

ghcide-bench/ghcide-bench.cabal

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ synopsis: An LSP client for running performance experiments on HLS
1212
description: An LSP client for running performance experiments on HLS
1313
homepage: https://github.com/haskell/haskell-language-server/tree/master/ghcide#readme
1414
bug-reports: https://github.com/haskell/haskell-language-server/issues
15-
tested-with: GHC == 8.10.7 || == 9.0.2 || == 9.2.5
15+
tested-with: GHC == 9.0.2 || == 9.2.5
1616

1717
source-repository head
1818
type: git

0 commit comments

Comments
 (0)