Warning -> Error

Author: drsooch

ghcide/src/Development/IDE/Plugin/HLS.hs

@@ -60,6 +60,7 @@ responseErrorToLogMessage err =  errorCode <> ":" <+> errorBody
         errorCode = pretty $ show $ err ^. LSP.code
         errorBody = pretty $ err ^. LSP.message
 
+-- various error message specific builders
 pluginNotEnabled :: SMethod m -> Text
 pluginNotEnabled method = "No plugin enabled for " <> T.pack (show method)
 
@@ -80,7 +81,7 @@ failedToParseArgs (CommandId com) (PluginId pid) err arg = "Error while parsing
 logAndReturnError :: Recorder (WithPriority Log) -> ErrorCode -> Text -> LSP.LspT Config IO (Either ResponseError a)
 logAndReturnError recorder errCode msg = do
     let err = ResponseError errCode msg Nothing
-    logWith recorder Warning $ LogPluginError err
+    logWith recorder Error $ LogPluginError err
     pure $ Left err
 
 -- | Map a set of plugins to the underlying ghcide engine.

plugins/hls-alternate-number-format-plugin/src/Ide/Plugin/AlternateNumberFormat.hs

@@ -97,7 +97,6 @@ codeActionHandler state plId (CodeActionParams _ _ docId currRange _) = pluginRe
         literalPairs = map (\lit -> (lit, alternateFormat lit)) litsInRange
         -- make a code action for every literal and its' alternates (then flatten the result)
         actions = concatMap (\(lit, alts) -> map (mkCodeAction nfp lit enabledExtensions pragma) alts) literalPairs
-
     pure $ List actions
     where
         inCurrentRange :: Literal -> Bool