Drop AGPL flag

Author: pepeiborra

README.md

@@ -301,7 +301,7 @@ For example, `haskell-language-server` allows you to choose the formatting provi
 This option obviously would not make sense for language servers for other languages, or even for other Haskell language servers (which need not even support formatting).
 
 Here is a list of the additional settings currently supported by `haskell-language-server`, along with their setting key (you may not need to know this) and default:
-- Formatting provider (`haskell.formattingProvider`, default `ormolu`): what formatter to use; one of `floskell`, `ormolu`, `fourmolu`, `stylish-haskell`, or `brittany` (if compiled with AGPL)
+- Formatting provider (`haskell.formattingProvider`, default `ormolu`): what formatter to use; one of `floskell`, `ormolu`, `fourmolu`, `stylish-haskell`, or `brittany` (if compiled with the brittany plugin)
 - Format on imports (`haskell.formatOnImportOn`, default true): whether to format after adding an import
 - Maximum number of problems to report (`haskell.maxNumberOfProblems`, default 100): the maximum number of problems the server will send to the client
 - Diagnostics on change (`haskell.diagnosticsOnChange`, default true): (currently unused)
@@ -648,7 +648,7 @@ This issue should be fixed in Stack versions >= 2.5.
 #### Problems with dynamic linking
 
 As haskell-language-server prebuilt binaries are statically linked, they don't play well with projects using dynamic linking.
-An usual symptom is the presence of errors containing `unknown symbol` and it is typical in arch linux, where a dynamically linked version of ghc is used. 
+An usual symptom is the presence of errors containing `unknown symbol` and it is typical in arch linux, where a dynamically linked version of ghc is used.
 
 The workaround is to use a version of haskell-language-server compiled from source with `-dynamic` enabled`. See more details [here](https://github.com/haskell/haskell-language-server/issues/1160#issuecomment-756566273).
 

docs/plugin-tutorial.md

@@ -96,9 +96,7 @@ idePlugins = pluginDescToIdePlugins allPlugins
       , Ormolu.descriptor   "ormolu"
       , StylishHaskell.descriptor "stylish-haskell"
       , Retrie.descriptor "retrie"
-#if AGPL
       , Brittany.descriptor    "brittany"
-#endif
       , Eval.descriptor "eval"
       ]
 ```

exe/Plugins.hs

@@ -71,7 +71,7 @@ import           Ide.Plugin.Ormolu         as Ormolu
 import           Ide.Plugin.StylishHaskell as StylishHaskell
 #endif
 
-#if AGPL && brittany
+#if brittany
 import           Ide.Plugin.Brittany       as Brittany
 #endif
 

haskell-language-server.cabal

@@ -20,11 +20,6 @@ extra-source-files:
   ChangeLog.md
   include/ghc-api-version.h
 
-flag agpl
-  description: Enable AGPL dependencies
-  default:     True
-  manual:      True
-
 flag pedantic
   description: Enable -Werror
   default:     False
@@ -34,10 +29,6 @@ source-repository head
   type:     git
   location: https://github.com/haskell/haskell-language-server
 
-common agpl
-  if flag(agpl)
-    cpp-options: -DAGPL
-
 common common-deps
   build-depends:
     , base       >=4.12 && <5
@@ -47,7 +38,7 @@ common common-deps
     , text
 
 library
-  import:           agpl, common-deps
+  import:           common-deps
   exposed-modules:
     Ide.Arguments
     Ide.Main
@@ -269,12 +260,11 @@ common stylishHaskell
     cpp-options: -DstylishHaskell
 
 common brittany
-  if (flag(brittany) || flag(all-formatters)) && flag(agpl)
+  if (flag(brittany) || flag(all-formatters))
     build-depends: hls-brittany-plugin ^>= 1.0.0.0
 
 executable haskell-language-server
-  import:             agpl
-                    , common-deps
+  import:             common-deps
                     -- plugins
                     , example-plugins
                     , class
@@ -346,7 +336,7 @@ executable haskell-language-server
   default-extensions: DataKinds, TypeOperators
 
 executable haskell-language-server-wrapper
-  import:           agpl, common-deps
+  import:           common-deps
   main-is:          Wrapper.hs
   hs-source-dirs:   exe
   other-modules:    Paths_haskell_language_server
@@ -379,7 +369,7 @@ executable haskell-language-server-wrapper
 -- We removed it due to issues with stack when loading the project using a stack based hie.yaml
 -- See https://github.com/haskell/haskell-language-server/issues/114
 common hls-test-utils
-  import:           agpl, common-deps
+  import:           common-deps
   hs-source-dirs:   test/utils
   other-modules:    Test.Hls.Util
   build-depends:
@@ -411,7 +401,7 @@ common hls-test-utils
   default-language: Haskell2010
 
 test-suite func-test
-  import:             agpl, common-deps, hls-test-utils
+  import:             common-deps, hls-test-utils
   type:               exitcode-stdio-1.0
   default-language:   Haskell2010
   build-tool-depends:
@@ -471,7 +461,7 @@ test-suite func-test
     ghc-options: -Werror -Wredundant-constraints
 
 test-suite wrapper-test
-  import:             agpl, hls-test-utils
+  import:             hls-test-utils
   type:               exitcode-stdio-1.0
   build-tool-depends:
     haskell-language-server:haskell-language-server-wrapper -any