Skip to content

Commit 0d9fd23

Browse files
fendormergify[bot]michaelpj
authored
Document cabal diagnostic options (#3971)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Michael Peyton Jones <[email protected]>
1 parent 86963df commit 0d9fd23

9 files changed

+35
-4
lines changed

plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal.hs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,9 @@ descriptor recorder plId =
114114
deleteFileOfInterest recorder ide file
115115
restartCabalShakeSession (shakeExtras ide) vfs file "(closed)"
116116
]
117+
, pluginConfigDescriptor = defaultConfigDescriptor
118+
{ configHasDiagnostics = True
119+
}
117120
}
118121
where
119122
log' = logWith recorder

test/testdata/schema/ghc92/default-config.golden.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
},
1010
"cabal": {
1111
"codeActionsOn": true,
12-
"completionOn": true
12+
"completionOn": true,
13+
"diagnosticsOn": true
1314
},
1415
"callHierarchy": {
1516
"globalOn": true

test/testdata/schema/ghc92/vscode-extension-schema.golden.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@
1717
"scope": "resource",
1818
"type": "boolean"
1919
},
20+
"haskell.plugin.cabal.diagnosticsOn": {
21+
"default": true,
22+
"description": "Enables cabal diagnostics",
23+
"scope": "resource",
24+
"type": "boolean"
25+
},
2026
"haskell.plugin.callHierarchy.globalOn": {
2127
"default": true,
2228
"description": "Enables callHierarchy plugin",

test/testdata/schema/ghc94/default-config.golden.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
},
1010
"cabal": {
1111
"codeActionsOn": true,
12-
"completionOn": true
12+
"completionOn": true,
13+
"diagnosticsOn": true
1314
},
1415
"callHierarchy": {
1516
"globalOn": true

test/testdata/schema/ghc94/vscode-extension-schema.golden.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@
1717
"scope": "resource",
1818
"type": "boolean"
1919
},
20+
"haskell.plugin.cabal.diagnosticsOn": {
21+
"default": true,
22+
"description": "Enables cabal diagnostics",
23+
"scope": "resource",
24+
"type": "boolean"
25+
},
2026
"haskell.plugin.callHierarchy.globalOn": {
2127
"default": true,
2228
"description": "Enables callHierarchy plugin",

test/testdata/schema/ghc96/default-config.golden.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
},
1010
"cabal": {
1111
"codeActionsOn": true,
12-
"completionOn": true
12+
"completionOn": true,
13+
"diagnosticsOn": true
1314
},
1415
"callHierarchy": {
1516
"globalOn": true

test/testdata/schema/ghc96/vscode-extension-schema.golden.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@
1717
"scope": "resource",
1818
"type": "boolean"
1919
},
20+
"haskell.plugin.cabal.diagnosticsOn": {
21+
"default": true,
22+
"description": "Enables cabal diagnostics",
23+
"scope": "resource",
24+
"type": "boolean"
25+
},
2026
"haskell.plugin.callHierarchy.globalOn": {
2127
"default": true,
2228
"description": "Enables callHierarchy plugin",

test/testdata/schema/ghc98/default-config.golden.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
},
1010
"cabal": {
1111
"codeActionsOn": true,
12-
"completionOn": true
12+
"completionOn": true,
13+
"diagnosticsOn": true
1314
},
1415
"callHierarchy": {
1516
"globalOn": true

test/testdata/schema/ghc98/vscode-extension-schema.golden.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@
1717
"scope": "resource",
1818
"type": "boolean"
1919
},
20+
"haskell.plugin.cabal.diagnosticsOn": {
21+
"default": true,
22+
"description": "Enables cabal diagnostics",
23+
"scope": "resource",
24+
"type": "boolean"
25+
},
2026
"haskell.plugin.callHierarchy.globalOn": {
2127
"default": true,
2228
"description": "Enables callHierarchy plugin",

0 commit comments

Comments
 (0)