Hlint hints.

Author: peterwicksstringfield

ghcide/.hlint.yaml

@@ -24,6 +24,9 @@
 - ignore: {name: "Use uncurry"}
 - ignore: {name: "Avoid lambda using `infix`"}
 
+# Gives at least one suggestion we don't like.
+- ignore: {name: "Use <=<"}
+
 # We are using the "redundant" return/pure to assign a name. We do not want to
 # delete it. In particular, this is not an improvement:
 # Found:

plugins/hls-eval-plugin/src/Ide/Plugin/Eval/CodeLens.hs

@@ -42,6 +42,7 @@ import Data.List
     (dropWhileEnd,
       find, intercalate
     )
+import Data.List.Extra (zipFrom)
 import qualified Data.Map.Strict as Map
 import Data.Maybe
     ( catMaybes,
@@ -405,7 +406,7 @@ moduleText uri =
 testsBySection :: [Section] -> [(Section, EvalId, Test)]
 testsBySection sections =
     [(section, ident, test)
-    | (ident, section) <- zip [0..] sections
+    | (ident, section) <- zipFrom 0 sections
     , test <- sectionTests section
     ]
 

plugins/hls-eval-plugin/src/Ide/Plugin/Eval/Types.hs

@@ -32,6 +32,7 @@ where
 import Control.DeepSeq (NFData (rnf), deepseq)
 import Data.Aeson (FromJSON, ToJSON)
 import Data.List (partition)
+import Data.List.Extra (zipWithFrom)
 import Data.List.NonEmpty (NonEmpty)
 import Data.Map.Strict (Map)
 import Data.String (IsString (..))
@@ -55,10 +56,8 @@ type Loc = Located Line
 
 type Line = Int
 
-{- HLINT ignore locate "Use zipWithFrom" -}
-
 locate :: Loc [a] -> [Loc a]
-locate (Located l tst) = zipWith Located [l ..] tst
+locate (Located l tst) = zipWithFrom Located l tst
 
 locate0 :: [a] -> [Loc a]
 locate0 = locate . Located 0

plugins/hls-tactics-plugin/src/Ide/Plugin/Tactic.hs

@@ -5,7 +5,6 @@
 {-# LANGUAGE NumDecimals         #-}
 {-# LANGUAGE OverloadedStrings   #-}
 {-# LANGUAGE ScopedTypeVariables #-}
-{-# LANGUAGE TupleSections       #-}
 {-# LANGUAGE ViewPatterns        #-}
 
 -- | A plugin that uses tactics to synthesize code

plugins/hls-tactics-plugin/src/Ide/Plugin/Tactic/Context.hs

@@ -21,9 +21,7 @@ import           TcRnTypes
 import           TcType (substTy, tcSplitSigmaTy)
 import           Unify (tcUnifyTy)
 
-
-{- HLINT ignore mkContext "Redundant fmap" -}
-{- HLINT ignore mkContext "Use <=<" -}
+{- HLINT ignore module "Redundant fmap" -}
 
 mkContext :: [(OccName, CType)] -> TcGblEnv -> Context
 mkContext locals tcg = Context
@@ -36,9 +34,6 @@ mkContext locals tcg = Context
   }
 
 
-
-{- HLINT ignore contextMethodHypothesis "Redundant fmap" -}
-
 ------------------------------------------------------------------------------
 -- | Find all of the class methods that exist from the givens in the context.
 contextMethodHypothesis :: Context -> Hypothesis CType

plugins/hls-tactics-plugin/src/Ide/Plugin/Tactic/Judgements.hs

@@ -35,6 +35,7 @@ import           Data.Bool
 import           Data.Char
 import           Data.Coerce
 import           Data.Generics.Product (field)
+import           Data.List.Extra (zipFrom)
 import           Data.Map (Map)
 import qualified Data.Map as M
 import           Data.Maybe
@@ -89,8 +90,6 @@ withNewGoal :: a -> Judgement' a -> Judgement' a
 withNewGoal t = field @"_jGoal" .~ t
 
 
-{- HLINT ignore introducing "Use zipFrom" -}
-
 ------------------------------------------------------------------------------
 -- | Helper function for implementing functions which introduce new hypotheses.
 introducing
@@ -100,7 +99,7 @@ introducing
     -> Judgement' a
     -> Judgement' a
 introducing f ns =
-  field @"_jHypothesis" <>~ (Hypothesis $ zip [0..] ns <&>
+  field @"_jHypothesis" <>~ (Hypothesis $ zipFrom 0 ns <&>
     \(pos, (name, ty)) -> HyInfo name (f pos) ty)
 
 
@@ -218,15 +217,11 @@ filterSameTypeFromOtherPositions dcon pos jdg =
    in disallowing Shadowed (M.keys to_remove) jdg
 
 
-{- HLINT ignore getAncestry "Replace case with maybe" -}
-
 ------------------------------------------------------------------------------
 -- | Return the ancestry of a 'PatVal', or 'mempty' otherwise.
 getAncestry :: Judgement' a -> OccName -> Set OccName
 getAncestry jdg name =
-  case M.lookup name $ jPatHypothesis jdg of
-    Just pv -> pv_ancestry pv
-    Nothing -> mempty
+  maybe mempty pv_ancestry (M.lookup name $ jPatHypothesis jdg)
 
 
 jAncestryMap :: Judgement' a -> Map OccName (Set OccName)