fix(server): email address validation

[tochicool]

Fixes #1073

[gbaz]

Thanks!

[ysangkok]

Hmm, had I broken this in #1047? I thought I just moved code around.

[ysangkok]

Oh indeed I did, by trying to prevent more than one at-sign. I had misunderstood what span does:

Prelude Data.Text> Data.Text.span (/= '@') $ pack "[email protected]"
("a","@b.com")

Sorry.

[andreasabel]

@ysangkok wrote:

Sorry.

Better unit test than sorry. ;-)

More seriously, I am worried that there is no beta deployment of Hackage. I voiced this during one of our jitsi meetings. I remember @gbaz saying that this is technically difficult. In principle, this should not be difficult. The database layer of Hackage needs to be separated from the UI layer, so that different UIs can connect to the same database. Maybe the current architecture does not permit this. Then we need to get some money to get the architecture modernized by some professionals like Well-Typed (who did the original architecture, AFAIK).

[andreasabel]

Better unit test than sorry. ;-)

Unit tests added in:

• Fix #1076: separate validators from UI and doctest them #1077