Skip to content

Install -prof packages? #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phadej opened this issue Nov 13, 2019 · 4 comments · Fixed by #64
Closed

Install -prof packages? #9

phadej opened this issue Nov 13, 2019 · 4 comments · Fixed by #64

Comments

@phadej
Copy link
Contributor

phadej commented Nov 13, 2019

It would make sense to have them in full images, but omit from -slim images.

I just run into a use case where I need -prof stuff.

opinions, @hvr @psftw?

@psftw
Copy link
Contributor

psftw commented Nov 19, 2019

Sounds reasonable, though if -prof is significantly bigger, it may make more sense to add a variant instead? I think we are stuck with quite large images due to GHC + dependencies, so the value of a -slim is questionable to me, but I have not looked at the numbers recently.

@phadej
Copy link
Contributor Author

phadej commented Nov 19, 2019

  • Rust has e.g. 1-slim-stretch tag, which downloaded a layer of size 371.3MB for me.
    • their slim vs stretch differ mainly in the choice of base image.
  • Haskell 8.4.4 main layer is is 244MB,

I think we can afford -prof in normal image and -slim can stay slim. That would be good for consistency with other official images. Our current image is what other call "slim": no extras.

@AlistairB
Copy link
Contributor

AlistairB commented Feb 20, 2022

I'm planning to implement this suggestion. I have seen people expect it recently and I think that is fairly reasonable. So..

  • Defaults will include profiling
  • Add -slim variants (for Debian only) which do not include profiling support and are based off of the debian -slim variants.
  • Alpine + Windows will also include profiling (when they are supported). I do not think I will add a slim variant here.

The profiling files take the image from 1.73GB -> 2.46GB (740mb) for 9.2 on Debian buster. Not the worst I guess. I think minimising image size is overrated.

I will ponder this more. On the flip side there has been little interest in including profiling libs.. hmm

@AlistairB
Copy link
Contributor

Decided to just pull the trigger as described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants