generate doc/requirements.txt #10031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
I'd expect some updates to documentation. e.g. doc/README.md. Maybe the Makefile.
Collaborator
Author
|
Yes, this is still WIP, let me switch it to draft. |
geekosaur
force-pushed
the
generate-requirements.txt
branch
from
19dcccd to
aaf052e
Compare
Collaborator
Author
|
Actually, I'm not sure we want to update the Makefile; it's going to be more necessary with this change, if someone wants to build docs locally. |
geekosaur
force-pushed
the
generate-requirements.txt
branch
4 times, most recently
from
7dd9d50 to
2aca7c4
Compare
Collaborator
Author
|
Okay, the basics now work. Documentation is next (tomorrow, I should go to bed…). |
Collaborator
|
This is magnificent, the less there is the harder it breaks. Many thanks! |
geekosaur
force-pushed
the
generate-requirements.txt
branch
2 times, most recently
from
a4ad174 to
17bc8c1
Compare
Collaborator
Author
|
First cut at documentation added. |
Collaborator
Author
|
ffaf1
approved these changes
May 18, 2024
ulysses4ever
approved these changes
May 19, 2024
Collaborator
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
Long awaited improvement, thank you very much!
geekosaur
force-pushed
the
generate-requirements.txt
branch
from
74c7a40 to
d0205af
Compare
geekosaur
added
merge me
mergify
bot
added
the
merge delay passed
2 tasks
As suggested in haskell#10030 (review)
As suggested in haskell#10030 (review)
geekosaur
force-pushed
the
generate-requirements.txt
branch
from
d0205af to
23e9c1a
Compare
Collaborator
Author
|
The reason this needs to be backported is that backports of subsequent changes to |
Collaborator
|
@mergify backport 3.12 |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 21, 2024
* generate doc/requirements.txt As suggested in #10030 (review) * generate doc/requirements.txt As suggested in #10030 (review) (cherry picked from commit 2658ac6)
2 tasks
Mikolaj
pushed a commit
that referenced
this pull request
May 22, 2024
* generate doc/requirements.txt As suggested in #10030 (review) * generate doc/requirements.txt As suggested in #10030 (review) (cherry picked from commit 2658ac6)
mergify bot
added a commit
that referenced
this pull request
May 22, 2024
generate doc/requirements.txt (backport #10031)
wismill
pushed a commit
to wismill/cabal
that referenced
this pull request
May 26, 2024
* generate doc/requirements.txt As suggested in haskell#10030 (review) * generate doc/requirements.txt As suggested in haskell#10030 (review)
wismill
pushed a commit
to wismill/cabal
that referenced
this pull request
May 27, 2024
* generate doc/requirements.txt As suggested in haskell#10030 (review) * generate doc/requirements.txt As suggested in haskell#10030 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #10030 (review)
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: