Skip to content

Commit fb58ed3

Browse files
committed
BUG: remove default service not existing message
1 parent d404fc5 commit fb58ed3

File tree

1 file changed

+9
-20
lines changed

1 file changed

+9
-20
lines changed

pkg/controller/global.go

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ package controller
1616

1717
import (
1818
"fmt"
19-
"time"
2019

2120
"github.com/go-test/deep"
2221

@@ -27,7 +26,6 @@ import (
2726
"github.com/haproxytech/kubernetes-ingress/pkg/haproxy/certs"
2827
"github.com/haproxytech/kubernetes-ingress/pkg/haproxy/env"
2928
"github.com/haproxytech/kubernetes-ingress/pkg/ingress"
30-
"github.com/haproxytech/kubernetes-ingress/pkg/k8s"
3129
"github.com/haproxytech/kubernetes-ingress/pkg/service"
3230
"github.com/haproxytech/kubernetes-ingress/pkg/store"
3331
)
@@ -183,7 +181,7 @@ func (c *HAProxyController) handleDefaultService() (reload bool) {
183181
return reload
184182
}
185183

186-
func populateDefaultLocalBackendResources(k8sStore store.K8s, eventChan chan k8s.SyncDataEvent, podNs string, defaultBackendPort int) error {
184+
func populateDefaultLocalBackendResources(k8sStore store.K8s, podNs string, defaultBackendPort int) error {
187185
controllerNs, ok := k8sStore.Namespaces[podNs]
188186
if !ok {
189187
return fmt.Errorf("controller namespace '%s' not found", podNs)
@@ -205,14 +203,9 @@ func populateDefaultLocalBackendResources(k8sStore store.K8s, eventChan chan k8s
205203
},
206204
},
207205
}
208-
eventProcessed := make(chan struct{})
209-
eventChan <- k8s.SyncDataEvent{SyncType: k8s.SERVICE, Namespace: item.Namespace, Data: item, EventProcessed: eventProcessed}
210-
timerService := time.NewTimer(time.Second)
211-
defer timerService.Stop()
212-
select {
213-
case <-timerService.C:
214-
case <-eventProcessed:
215-
}
206+
k8sStore.EventService(controllerNs, item)
207+
logger.Debug("default backend event service processed")
208+
216209
endpoints := &store.Endpoints{
217210
Namespace: podNs,
218211
Service: store.DefaultLocalBackend,
@@ -225,14 +218,10 @@ func populateDefaultLocalBackendResources(k8sStore store.K8s, eventChan chan k8s
225218
},
226219
},
227220
}
228-
eventProcessed = make(chan struct{})
229-
eventChan <- k8s.SyncDataEvent{SyncType: k8s.ENDPOINTS, Namespace: endpoints.Namespace, Data: endpoints, EventProcessed: eventProcessed}
230-
timerEndpoints := time.NewTimer(time.Second)
231-
defer timerEndpoints.Stop()
232-
select {
233-
case <-timerEndpoints.C:
234-
case <-eventProcessed:
235-
}
221+
k8sStore.EventEndpoints(controllerNs, endpoints, nil)
222+
logger.Debug("default backend event endpoints processed")
223+
} else {
224+
defaultLocalService.Annotations = k8sStore.ConfigMaps.Main.Annotations
236225
}
237226
return nil
238227
}
@@ -242,7 +231,7 @@ func (c *HAProxyController) handleDefaultLocalService() (reload bool) {
242231
err error
243232
svc *service.Service
244233
)
245-
err = populateDefaultLocalBackendResources(c.store, c.eventChan, c.podNamespace, c.osArgs.DefaultBackendPort)
234+
err = populateDefaultLocalBackendResources(c.store, c.podNamespace, c.osArgs.DefaultBackendPort)
246235
if err != nil {
247236
logger.Error(err)
248237
return

0 commit comments

Comments
 (0)