Skip to content

Commit f468a7b

Browse files
committed
DOC/MINOR: sync-period: clarify helm usage
1 parent e71a334 commit f468a7b

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

documentation/controller.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -549,7 +549,7 @@ Example:
549549

550550
### `--sync-period`
551551

552-
The interval at which the controller syncs its configuration with updated Kubernetes objects.
552+
The interval at which the controller syncs its configuration with updated Kubernetes objects. In the case where the ingress controller is reloading too frequently, a higher value may be required. Note, if using helm charts you must also adjust the `startupProbe`'s `initialDelaySeconds` value. Its value must be higher than the `--sync-period` value.
553553

554554
Possible values:
555555

@@ -791,7 +791,7 @@ Example:
791791

792792
```yaml
793793
args:
794-
- --quic-bind-port=4443
794+
- --quic-bind-port=4443
795795
```
796796

797797
<p align='right'><a href='#haproxy-kubernetes-ingress-controller'>:arrow_up_small: back to top</a></p>

documentation/doc.yaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -279,15 +279,16 @@ image_arguments:
279279
helm install haproxy haproxytech/kubernetes-ingress \
280280
--set-string "controller.extraArgs={--disable-https}"
281281
- argument: --sync-period
282-
description: The interval at which the controller syncs its configuration with updated Kubernetes objects.
282+
description: The interval at which the controller syncs its configuration with updated Kubernetes objects. In the case where the ingress controller is reloading too frequently, a higher value may be required. Note, if using helm charts you must also adjust the `startupProbe`'s `initialDelaySeconds` value. Its value must be higher than the `--sync-period` value.
283283
values:
284284
- An integer with unit of time (1s = 1 second, 1m = 1 minute, 1h = 1 hour); Defaults to 5s
285285
default: 5s
286286
version_min: "1.4"
287287
example: --sync-period=10s
288288
helm: |-
289289
helm install haproxy haproxytech/kubernetes-ingress \
290-
--set-string "controller.extraArgs={--sync-period=10s}"
290+
--set-string "controller.extraArgs={--sync-period=60s}" \
291+
--set controller.startupProbe.initialDelaySeconds=80
291292
- argument: --cache-resync-period
292293
description: Sets the default re-synchronization period at which the controller will re-apply the desired state.
293294
values:
@@ -388,7 +389,7 @@ image_arguments:
388389
version_min: "1.11"
389390
example: |-
390391
args:
391-
- --quic-bind-port=4443
392+
- --quic-bind-port=4443
392393
groups:
393394
config-snippet:
394395
header: |-
@@ -1183,7 +1184,7 @@ annotations:
11831184
applies_to:
11841185
- configmap
11851186
version_min: "1.11"
1186-
example: ['quic-alt-svc-max-age: "900"']
1187+
example: ['quic-alt-svc-max-age: "900"']
11871188
- title: rate-limit-period
11881189
type: "[time](#time)"
11891190
group: rate-limit
@@ -1585,7 +1586,7 @@ annotations:
15851586
tip:
15861587
- Traffic is proxied in TCP mode which makes unavailable a number of the controller
15871588
annotations (requiring HTTP mode).
1588-
- HTTPS frontend is conserved and still listening at port 8444 when previous HTTPS port is moved to SSL Frontend.
1589+
- HTTPS frontend is conserved and still listening at port 8444 when previous HTTPS port is moved to SSL Frontend.
15891590
values:
15901591
- "true"
15911592
- "false"

0 commit comments

Comments
 (0)