MINOR: remove any config snippet from pprof backend

Author: ivanmatmati

pkg/annotations/cfgSnippetHandler.go

@@ -13,7 +13,7 @@ type ConfigSnippetHandler struct{}
 
 func (h ConfigSnippetHandler) Update(k store.K8s, api haproxy.HAProxy, ann Annotations) (reload bool, err error) {
 	// We get the configmap configsnippet value
-	configmapCfgSnippetValue, errConfigmapCfgSnippet := getConfigmapConfigSnippet(api)
+	configmapCfgSnippetValue, errConfigmapCfgSnippet := getConfigmapConfigSnippet(k.BackendsWithNoConfigSnippets, api)
 	if errConfigmapCfgSnippet != nil {
 		return false, errConfigmapCfgSnippet
 	}
@@ -22,7 +22,7 @@ func (h ConfigSnippetHandler) Update(k store.K8s, api haproxy.HAProxy, ann Annot
 	return
 }
 
-func getConfigmapConfigSnippet(api api.HAProxyClient) (configmapCfgSnippetValue []string, err error) {
+func getConfigmapConfigSnippet(backendsWithNoConfigSnippets map[string]struct{}, api api.HAProxyClient) (configmapCfgSnippetValue []string, err error) {
 	// configmap config snippet if any.
 	configmapCfgSnippetValue = []string{}
 	// configmap config snippet will be hold in special backend 'configmap' with origin 'configmap'
@@ -34,6 +34,9 @@ func getConfigmapConfigSnippet(api api.HAProxyClient) (configmapCfgSnippetValue
 		// to replicate everywhere the configmap insertion.
 		if backends, errGet := api.BackendsGet(); errGet == nil {
 			for _, backend := range backends {
+				if _, ok := backendsWithNoConfigSnippets[backend.Name]; ok {
+					continue
+				}
 				if _, ok := cfgSnippet.backends[backend.Name]; !ok {
 					cfgSnippet.backends[backend.Name] = map[string]*cfgData{
 						"configmap-insertion": {status: store.ADDED},

pkg/handler/pprof.go

@@ -23,11 +23,12 @@ import (
 	"github.com/haproxytech/kubernetes-ingress/pkg/store"
 )
 
+const pprofBackend = "pprof"
+
 type Pprof struct{}
 
 func (handler Pprof) Update(k store.K8s, h haproxy.HAProxy, a annotations.Annotations) (reload bool, err error) {
-	pprofBackend := "pprof"
-
+	k.BackendsWithNoConfigSnippets[pprofBackend] = struct{}{}
 	_, err = h.BackendGet(pprofBackend)
 	if err != nil {
 		err = h.BackendCreatePermanently(models.Backend{
@@ -38,7 +39,7 @@ func (handler Pprof) Update(k store.K8s, h haproxy.HAProxy, a annotations.Annota
 			return
 		}
 		err = h.BackendServerCreate(pprofBackend, models.Server{
-			Name:    "pprof",
+			Name:    pprofBackend,
 			Address: "127.0.0.1:6060",
 		})
 		if err != nil {

pkg/store/store.go

@@ -24,17 +24,18 @@ import (
 const DefaultLocalBackend = "default-local-service"
 
 type K8s struct {
-	ConfigMaps              ConfigMaps
-	NamespacesAccess        NamespacesWatch
-	Namespaces              map[string]*Namespace
-	IngressClasses          map[string]*IngressClass
-	SecretsProcessed        map[string]struct{}
-	BackendsProcessed       map[string]struct{}
-	GatewayClasses          map[string]*GatewayClass
-	GatewayControllerName   string
-	PublishServiceAddresses []string
-	NbrHAProxyInst          int64
-	UpdateAllIngresses      bool
+	ConfigMaps                   ConfigMaps
+	NamespacesAccess             NamespacesWatch
+	Namespaces                   map[string]*Namespace
+	IngressClasses               map[string]*IngressClass
+	SecretsProcessed             map[string]struct{}
+	BackendsProcessed            map[string]struct{}
+	GatewayClasses               map[string]*GatewayClass
+	GatewayControllerName        string
+	PublishServiceAddresses      []string
+	NbrHAProxyInst               int64
+	UpdateAllIngresses           bool
+	BackendsWithNoConfigSnippets map[string]struct{}
 }
 
 type NamespacesWatch struct {
@@ -72,9 +73,10 @@ func NewK8sStore(args utils.OSArgs) K8s {
 				Name:      args.ConfigMapPatternFiles.Name,
 			},
 		},
-		SecretsProcessed:  map[string]struct{}{},
-		BackendsProcessed: map[string]struct{}{},
-		GatewayClasses:    make(map[string]*GatewayClass),
+		SecretsProcessed:             map[string]struct{}{},
+		BackendsProcessed:            map[string]struct{}{},
+		GatewayClasses:               map[string]*GatewayClass{},
+		BackendsWithNoConfigSnippets: map[string]struct{}{},
 	}
 	for _, namespace := range args.NamespaceWhitelist {
 		store.NamespacesAccess.Whitelist[namespace] = struct{}{}