BUG/MINOR: Prevents improper overriding of DefaultServer when processing the proto annotation

fabianonunes · oktalz · commit 6a67203299d6 · 2024-05-03T10:47:23.000+02:00
diff --git a/pkg/annotations/service/proto.go b/pkg/annotations/service/proto.go
@@ -25,7 +25,7 @@ func (a *Proto) GetName() string {
 func (a *Proto) Process(k store.K8s, annotations ...map[string]string) error {
 	input := common.GetValue(a.GetName(), annotations...)
 	if input == "h2" {
-		if a.backend.DefaultServer != nil {
+		if a.backend.DefaultServer == nil {
 			a.backend.DefaultServer = &models.DefaultServer{}
 		}
 		a.backend.DefaultServer.Proto = "h2"

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ func (a *Proto) GetName() string {`
`25`	`25`	`func (a *Proto) Process(k store.K8s, annotations ...map[string]string) error {`
`26`	`26`	`input := common.GetValue(a.GetName(), annotations...)`
`27`	`27`	`if input == "h2" {`
`28`		`- if a.backend.DefaultServer != nil {`
	`28`	`+ if a.backend.DefaultServer == nil {`
`29`	`29`	`a.backend.DefaultServer = &models.DefaultServer{}`
`30`	`30`	`}`
`31`	`31`	`a.backend.DefaultServer.Proto = "h2"`