Skip to content

Commit 302a139

Browse files
committed
MINOR: ensure both ClusterIP and ExternalIPs are added in publish service
1 parent f329042 commit 302a139

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pkg/k8s/informers.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -714,12 +714,12 @@ func getServiceAddresses(service *corev1.Service) (addresses []string) {
714714
addresses = []string{service.Spec.ExternalName}
715715
case corev1.ServiceTypeClusterIP:
716716
addresses = []string{service.Spec.ClusterIP}
717+
addresses = append(addresses, service.Spec.ExternalIPs...)
717718
case corev1.ServiceTypeNodePort:
718-
if service.Spec.ExternalIPs != nil {
719-
addresses = append(addresses, service.Spec.ExternalIPs...)
720-
} else {
719+
if service.Spec.ClusterIP == "" {
721720
addresses = append(addresses, service.Spec.ClusterIP)
722721
}
722+
addresses = append(addresses, service.Spec.ExternalIPs...)
723723
case corev1.ServiceTypeLoadBalancer:
724724
for _, ip := range service.Status.LoadBalancer.Ingress {
725725
if ip.IP == "" {

0 commit comments

Comments
 (0)