Skip to content

Commit 0dd67a1

Browse files
committed
BUG/MINOR: crd: do not convert if zero value is set for value
1 parent e54beae commit 0dd67a1

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

crs/converters/backend-spec.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515
package converters
1616

1717
import (
18-
"github.com/haproxytech/client-native/v5/misc"
1918
"github.com/haproxytech/client-native/v5/models"
2019

2120
corev1alpha2 "github.com/haproxytech/kubernetes-ingress/crs/api/core/v1alpha2"
2221
v1 "github.com/haproxytech/kubernetes-ingress/crs/api/ingress/v1"
22+
"github.com/haproxytech/kubernetes-ingress/pkg/utils"
2323
)
2424

2525
func DeepConvertBackendSpecA2toV1(o corev1alpha2.BackendSpec) v1.BackendSpec { //nolint:cyclop,maintidx
@@ -153,7 +153,7 @@ func DeepConvertBackendSpecA2toV1(o corev1alpha2.BackendSpec) v1.BackendSpec { /
153153
cp.Config.DefaultServer.HealthCheckPort = new(int64)
154154
cp.Config.DefaultServer.HealthCheckPort = o.Config.DefaultServer.HealthCheckPort
155155
}
156-
cp.Config.DefaultServer.InitAddr = misc.Ptr(o.Config.DefaultServer.InitAddr)
156+
cp.Config.DefaultServer.InitAddr = utils.PointerIfNotDefault(o.Config.DefaultServer.InitAddr)
157157
if o.Config.DefaultServer.Inter != nil {
158158
cp.Config.DefaultServer.Inter = new(int64)
159159
cp.Config.DefaultServer.Inter = o.Config.DefaultServer.Inter
@@ -235,7 +235,7 @@ func DeepConvertBackendSpecA2toV1(o corev1alpha2.BackendSpec) v1.BackendSpec { /
235235
cp.Config.DefaultServer.SslMinVer = o.Config.DefaultServer.SslMinVer
236236
cp.Config.DefaultServer.SslReuse = o.Config.DefaultServer.SslReuse
237237
cp.Config.DefaultServer.Stick = o.Config.DefaultServer.Stick
238-
cp.Config.DefaultServer.TCPUt = misc.Ptr(o.Config.DefaultServer.TCPUt)
238+
cp.Config.DefaultServer.TCPUt = utils.PointerIfNotDefault(o.Config.DefaultServer.TCPUt)
239239
cp.Config.DefaultServer.Tfo = o.Config.DefaultServer.Tfo
240240
cp.Config.DefaultServer.TLSTickets = o.Config.DefaultServer.TLSTickets
241241
cp.Config.DefaultServer.Track = o.Config.DefaultServer.Track

crs/converters/defaults-spec.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020

2121
corev1alpha2 "github.com/haproxytech/kubernetes-ingress/crs/api/core/v1alpha2"
2222
v1 "github.com/haproxytech/kubernetes-ingress/crs/api/ingress/v1"
23+
"github.com/haproxytech/kubernetes-ingress/pkg/utils"
2324
)
2425

2526
func DeepConvertDefaultsSpecA2toV1(o corev1alpha2.DefaultsSpec) v1.DefaultsSpec { //nolint:cyclop,maintidx
@@ -176,7 +177,7 @@ func DeepConvertDefaultsSpecA2toV1(o corev1alpha2.DefaultsSpec) v1.DefaultsSpec
176177
cp.Config.DefaultServer.HealthCheckPort = new(int64)
177178
cp.Config.DefaultServer.HealthCheckPort = o.Config.DefaultServer.HealthCheckPort
178179
}
179-
cp.Config.DefaultServer.InitAddr = misc.Ptr(o.Config.DefaultServer.InitAddr)
180+
cp.Config.DefaultServer.InitAddr = utils.PointerIfNotDefault(o.Config.DefaultServer.InitAddr)
180181
if o.Config.DefaultServer.Inter != nil {
181182
cp.Config.DefaultServer.Inter = new(int64)
182183
cp.Config.DefaultServer.Inter = o.Config.DefaultServer.Inter

0 commit comments

Comments
 (0)