Skip to content

Commit 46d094b

Browse files
committed
Remove findByViewId()
And use one less object.
1 parent 6a4187f commit 46d094b

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

app/src/main/java/tk/superl2/xwifi/MainActivity.kt

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,14 @@ import android.util.Log
1010
import android.view.Menu
1111
import android.view.MenuItem
1212
import android.widget.*
13+
import kotlinx.android.synthetic.main.activity_main.*
1314
import net.glxn.qrgen.android.QRCode
1415
import net.glxn.qrgen.core.scheme.Wifi
1516

1617
const val TAG = "MainActivity"
1718
const val QR_GENERATION_RESOLUTION = 300
1819

1920
class MainActivity: Activity() {
20-
// ListView reference object
21-
private lateinit var mWifiListView: ListView
2221
// This variable holds an ArrayList of WifiEntry objects that each contain a saved wifi SSID and
2322
// password. It is updated whenever focus returns to the app (onResume).
2423
private lateinit var wifiEntries: ArrayList<WifiEntry>
@@ -30,9 +29,8 @@ class MainActivity: Activity() {
3029
super.onCreate(savedInstanceState)
3130
setContentView(R.layout.activity_main)
3231

33-
mWifiListView = findViewById(R.id.wifi_ListView)
34-
mWifiListView.adapter = ArrayAdapter(this, android.R.layout.simple_list_item_1, wifiEntrySSIDs)
35-
mWifiListView.setOnItemClickListener { _, _, position, _ ->
32+
wifi_ListView.adapter = ArrayAdapter(this, android.R.layout.simple_list_item_1, wifiEntrySSIDs)
33+
wifi_ListView.setOnItemClickListener { _, _, position, _ ->
3634
val qrCodeView = ImageView(this)
3735
qrCodeView.setPadding(0, 0, 0, -60)
3836
qrCodeView.adjustViewBounds = true
@@ -50,7 +48,7 @@ class MainActivity: Activity() {
5048
qrDialog = builder.create()
5149
qrDialog.show()
5250
}
53-
mWifiListView.setOnItemLongClickListener { _, _, position, _ ->
51+
wifi_ListView.setOnItemLongClickListener { _, _, position, _ ->
5452
val builder = AlertDialog.Builder(this)
5553
builder.setMessage(Html.fromHtml(
5654
"<b>SSID</b>: ${wifiEntries[position].title}<br>" +
@@ -95,7 +93,7 @@ class MainActivity: Activity() {
9593
loadWifiEntries()
9694
}
9795
override fun onPostExecute(result: Unit?) {
98-
(mWifiListView.adapter as ArrayAdapter<*>).notifyDataSetChanged()
96+
(wifi_ListView.adapter as ArrayAdapter<*>).notifyDataSetChanged()
9997
runOnUiThread { loadingDialog.dismiss() }
10098
}
10199

0 commit comments

Comments
 (0)