fixed data race on acknowledgedIncomingBytes in class BinderTransport.java

raulpardo · raulpardo · commit 4748ad22a542 · 2025-03-27T10:35:52.000+01:00
diff --git a/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java b/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java
@@ -484,8 +484,8 @@ private boolean handleTransactionInternal(int code, Parcel parcel) {
         inbound.handleTransaction(parcel);
       }
       long nib = numIncomingBytes.addAndGet(size);
-      if ((nib - acknowledgedIncomingBytes) > TRANSACTION_BYTES_WINDOW_FORCE_ACK) {
-        synchronized (this) {
+      synchronized (this) {
+        if ((nib - acknowledgedIncomingBytes) > TRANSACTION_BYTES_WINDOW_FORCE_ACK) {
           sendAcknowledgeBytes(checkNotNull(outgoingBinder));
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -484,8 +484,8 @@ private boolean handleTransactionInternal(int code, Parcel parcel) {`
`484`	`484`	`inbound.handleTransaction(parcel);`
`485`	`485`	`}`
`486`	`486`	`long nib = numIncomingBytes.addAndGet(size);`
`487`		`- if ((nib - acknowledgedIncomingBytes) > TRANSACTION_BYTES_WINDOW_FORCE_ACK) {`
`488`		`- synchronized (this) {`
	`487`	`+ synchronized (this) {`
	`488`	`+ if ((nib - acknowledgedIncomingBytes) > TRANSACTION_BYTES_WINDOW_FORCE_ACK) {`
`489`	`489`	`sendAcknowledgeBytes(checkNotNull(outgoingBinder));`
`490`	`490`	`}`
`491`	`491`	`}`