From 0148122a2ff834f015b901591be64201c10eac00 Mon Sep 17 00:00:00 2001 From: Purnesh Dixit Date: Thu, 1 Aug 2024 21:00:07 +0530 Subject: [PATCH 1/7] Add github.com/mgechev/revive --- scripts/vet.sh | 6 ++++- test/tools/go.mod | 19 +++++++++++++-- test/tools/go.sum | 58 +++++++++++++++++++++++++++++++++++++++++---- test/tools/tools.go | 1 + 4 files changed, 77 insertions(+), 7 deletions(-) diff --git a/scripts/vet.sh b/scripts/vet.sh index c32b6ea35ecf..daf5fc72da59 100755 --- a/scripts/vet.sh +++ b/scripts/vet.sh @@ -30,7 +30,8 @@ if [[ "$1" = "-install" ]]; then go install \ golang.org/x/tools/cmd/goimports \ honnef.co/go/tools/cmd/staticcheck \ - github.com/client9/misspell/cmd/misspell + github.com/client9/misspell/cmd/misspell \ + github.com/mgechev/revive popd exit 0 elif [[ "$#" -ne 0 ]]; then @@ -95,6 +96,9 @@ for MOD_FILE in $(find . -name 'go.mod'); do SC_OUT="$(mktemp)" staticcheck -go 1.21 -checks 'all' ./... >"${SC_OUT}" || true + # - Collection of revive linter analysis checks + revive -formatter friendly $MOD_DIR/... || true + # Error for anything other than checks that need exclusions. noret_grep -v "(ST1000)" "${SC_OUT}" | noret_grep -v "(SA1019)" | noret_grep -v "(ST1003)" | noret_grep -v "(ST1019)\|\(other import of\)" | not grep -v "(SA4000)" diff --git a/test/tools/go.mod b/test/tools/go.mod index 0d300d9c2d23..a4c51f7aedd8 100644 --- a/test/tools/go.mod +++ b/test/tools/go.mod @@ -4,14 +4,29 @@ go 1.21 require ( github.com/client9/misspell v0.3.4 - golang.org/x/tools v0.22.0 + github.com/mgechev/revive v1.3.9 + golang.org/x/tools v0.23.0 google.golang.org/protobuf v1.34.1 honnef.co/go/tools v0.4.7 ) require ( github.com/BurntSushi/toml v1.4.0 // indirect + github.com/chavacava/garif v0.1.0 // indirect + github.com/fatih/color v1.17.0 // indirect + github.com/fatih/structtag v1.2.0 // indirect + github.com/hashicorp/go-version v1.7.0 // indirect + github.com/mattn/go-colorable v0.1.13 // indirect + github.com/mattn/go-isatty v0.0.20 // indirect + github.com/mattn/go-runewidth v0.0.9 // indirect + github.com/mgechev/dots v0.0.0-20210922191527-e955255bf517 // indirect + github.com/mitchellh/go-homedir v1.1.0 // indirect + github.com/olekukonko/tablewriter v0.0.5 // indirect + github.com/pkg/errors v0.9.1 // indirect + github.com/spf13/afero v1.11.0 // indirect golang.org/x/exp/typeparams v0.0.0-20240604190554-fc45aab8b7f8 // indirect - golang.org/x/mod v0.18.0 // indirect + golang.org/x/mod v0.19.0 // indirect golang.org/x/sync v0.7.0 // indirect + golang.org/x/sys v0.22.0 // indirect + golang.org/x/text v0.14.0 // indirect ) diff --git a/test/tools/go.sum b/test/tools/go.sum index 36b23ebebc9b..44f4191f1583 100644 --- a/test/tools/go.sum +++ b/test/tools/go.sum @@ -1,18 +1,68 @@ github.com/BurntSushi/toml v1.4.0 h1:kuoIxZQy2WRRk1pttg9asf+WVv6tWQuBNVmK8+nqPr0= github.com/BurntSushi/toml v1.4.0/go.mod h1:ukJfTF/6rtPPRCnwkur4qwRxa8vTRFBF0uk2lLoLwho= +github.com/chavacava/garif v0.1.0 h1:2JHa3hbYf5D9dsgseMKAmc/MZ109otzgNFk5s87H9Pc= +github.com/chavacava/garif v0.1.0/go.mod h1:XMyYCkEL58DF0oyW4qDjjnPWONs2HBqYKI+UIPD+Gww= github.com/client9/misspell v0.3.4 h1:ta993UF76GwbvJcIo3Y68y/M3WxlpEHPWIGDkJYwzJI= github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw= +github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= +github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= +github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= +github.com/fatih/color v1.17.0 h1:GlRw1BRJxkpqUCBKzKOw098ed57fEsKeNjpTe3cSjK4= +github.com/fatih/color v1.17.0/go.mod h1:YZ7TlrGPkiz6ku9fK3TLD/pl3CpsiFyu8N92HLgmosI= +github.com/fatih/structtag v1.2.0 h1:/OdNE99OxoI/PqaW/SuSK9uxxT3f/tcSZgon/ssNSx4= +github.com/fatih/structtag v1.2.0/go.mod h1:mBJUNpUnHmRKrKlQQlmCrh5PuhftFbNv8Ys4/aAZl94= github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI= github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY= +github.com/hashicorp/go-version v1.7.0 h1:5tqGy27NaOTB8yJKUZELlFAS/LTKJkrmONwQKeRZfjY= +github.com/hashicorp/go-version v1.7.0/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09ZGVZPK5anwXA= +github.com/mattn/go-colorable v0.1.13 h1:fFA4WZxdEF4tXPZVKMLwD8oUnCTTo08duU7wxecdEvA= +github.com/mattn/go-colorable v0.1.13/go.mod h1:7S9/ev0klgBDR4GtXTXX8a3vIGJpMovkB8vQcUbaXHg= +github.com/mattn/go-isatty v0.0.16/go.mod h1:kYGgaQfpe5nmfYZH+SKPsOc2e4SrIfOl2e/yFXSvRLM= +github.com/mattn/go-isatty v0.0.20 h1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWEY= +github.com/mattn/go-isatty v0.0.20/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y= +github.com/mattn/go-runewidth v0.0.9 h1:Lm995f3rfxdpd6TSmuVCHVb/QhupuXlYr8sCI/QdE+0= +github.com/mattn/go-runewidth v0.0.9/go.mod h1:H031xJmbD/WCDINGzjvQ9THkh0rPKHF+m2gUSrubnMI= +github.com/mgechev/dots v0.0.0-20210922191527-e955255bf517 h1:zpIH83+oKzcpryru8ceC6BxnoG8TBrhgAvRg8obzup0= +github.com/mgechev/dots v0.0.0-20210922191527-e955255bf517/go.mod h1:KQ7+USdGKfpPjXk4Ga+5XxQM4Lm4e3gAogrreFAYpOg= +github.com/mgechev/revive v1.3.9 h1:18Y3R4a2USSBF+QZKFQwVkBROUda7uoBlkEuBD+YD1A= +github.com/mgechev/revive v1.3.9/go.mod h1:+uxEIr5UH0TjXWHTno3xh4u7eg6jDpXKzQccA9UGhHU= +github.com/mitchellh/go-homedir v1.1.0 h1:lukF9ziXFxDFPkA1vsr5zpc1XuPDn/wFntq5mG+4E0Y= +github.com/mitchellh/go-homedir v1.1.0/go.mod h1:SfyaCUpYCn1Vlf4IUYiD9fPX4A5wJrkLzIz1N1q0pr0= +github.com/olekukonko/tablewriter v0.0.5 h1:P2Ga83D34wi1o9J6Wh1mRuqd4mF/x/lgBS7N7AbDhec= +github.com/olekukonko/tablewriter v0.0.5/go.mod h1:hPp6KlRPjbx+hW8ykQs1w3UBbZlj6HuIJcUGPhkA7kY= +github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4= +github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0= +github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= +github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= +github.com/spf13/afero v1.11.0 h1:WJQKhtpdm3v2IzqG8VMqrr6Rf3UYpEF239Jy9wNepM8= +github.com/spf13/afero v1.11.0/go.mod h1:GH9Y3pIexgf1MTIWtNGyogA5MwRIDXGUr+hbWNoBjkY= +github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME= +github.com/stretchr/objx v0.4.0/go.mod h1:YvHI0jy2hoMjB+UWwv71VJQ9isScKT/TqJzVSSt89Yw= +github.com/stretchr/objx v0.5.0/go.mod h1:Yh+to48EsGEfYuaHDzXPcE3xhTkx73EhmCGUpEOglKo= +github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg= +github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU= +github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo= +github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg= +github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY= golang.org/x/exp/typeparams v0.0.0-20240604190554-fc45aab8b7f8 h1:WKP3FgLqWfVutBnw/dr+LNg4fzjyTQP5o+ELTIyoBrs= golang.org/x/exp/typeparams v0.0.0-20240604190554-fc45aab8b7f8/go.mod h1:AbB0pIl9nAr9wVwH+Z2ZpaocVmF5I4GyWCDIsVjR0bk= -golang.org/x/mod v0.18.0 h1:5+9lSbEzPSdWkH32vYPBwEpX8KwDbM52Ud9xBUvNlb0= -golang.org/x/mod v0.18.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c= +golang.org/x/mod v0.19.0 h1:fEdghXQSo20giMthA7cd28ZC+jts4amQ3YMXiP5oMQ8= +golang.org/x/mod v0.19.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c= golang.org/x/sync v0.7.0 h1:YsImfSBoP9QPYL0xyKJPq0gcaJdG3rInoqxTWbfQu9M= golang.org/x/sync v0.7.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk= -golang.org/x/tools v0.22.0 h1:gqSGLZqv+AI9lIQzniJ0nZDRG5GBPsSi+DRNHWNz6yA= -golang.org/x/tools v0.22.0/go.mod h1:aCwcsjqvq7Yqt6TNyX7QMU2enbQ/Gt0bo6krSeEri+c= +golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= +golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= +golang.org/x/sys v0.22.0 h1:RI27ohtqKCnwULzJLqkv897zojh5/DwS/ENaMzUOaWI= +golang.org/x/sys v0.22.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA= +golang.org/x/text v0.14.0 h1:ScX5w1eTa3QqT8oi6+ziP7dTV1S2+ALU0bI+0zXKWiQ= +golang.org/x/text v0.14.0/go.mod h1:18ZOQIKpY8NJVqYksKHtTdi31H5itFRjB5/qKTNYzSU= +golang.org/x/tools v0.23.0 h1:SGsXPZ+2l4JsgaCKkx+FQ9YZ5XEtA1GZYuoDjenLjvg= +golang.org/x/tools v0.23.0/go.mod h1:pnu6ufv6vQkll6szChhK3C3L/ruaIv5eBeztNG8wtsI= google.golang.org/protobuf v1.34.1 h1:9ddQBjfCyZPOHPUiPxpYESBLc+T8P3E+Vo4IbKZgFWg= google.golang.org/protobuf v1.34.1/go.mod h1:c6P6GXX6sHbq/GpV6MGZEdwhWPcYBgnhAHhKbcUYpos= +gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= +gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= +gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA= +gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= honnef.co/go/tools v0.4.7 h1:9MDAWxMoSnB6QoSqiVr7P5mtkT9pOc1kSxchzPCnqJs= honnef.co/go/tools v0.4.7/go.mod h1:+rnGS1THNh8zMwnd2oVOTL9QF6vmfyG6ZXBULae2uc0= diff --git a/test/tools/tools.go b/test/tools/tools.go index a192fd37cfbe..2edd38466f91 100644 --- a/test/tools/tools.go +++ b/test/tools/tools.go @@ -27,6 +27,7 @@ package tools import ( _ "github.com/client9/misspell/cmd/misspell" + _ "github.com/mgechev/revive" _ "golang.org/x/tools/cmd/goimports" _ "google.golang.org/protobuf/cmd/protoc-gen-go" _ "honnef.co/go/tools/cmd/staticcheck" From 90c7debce9a100d5a59fc6c9303dede5e1d3a973 Mon Sep 17 00:00:00 2001 From: Purnesh Dixit Date: Thu, 1 Aug 2024 23:47:49 +0530 Subject: [PATCH 2/7] only print the linting issues --- scripts/vet.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/vet.sh b/scripts/vet.sh index daf5fc72da59..7c7a9b11f8e7 100755 --- a/scripts/vet.sh +++ b/scripts/vet.sh @@ -97,7 +97,7 @@ for MOD_FILE in $(find . -name 'go.mod'); do staticcheck -go 1.21 -checks 'all' ./... >"${SC_OUT}" || true # - Collection of revive linter analysis checks - revive -formatter friendly $MOD_DIR/... || true + echo $(revive -formatter friendly $MOD_DIR/...) || true # Error for anything other than checks that need exclusions. noret_grep -v "(ST1000)" "${SC_OUT}" | noret_grep -v "(SA1019)" | noret_grep -v "(ST1003)" | noret_grep -v "(ST1019)\|\(other import of\)" | not grep -v "(SA4000)" From 5ae9cd391b67d7dd4429ff16a6dc13546ac18683 Mon Sep 17 00:00:00 2001 From: Purnesh Dixit Date: Thu, 1 Aug 2024 23:51:18 +0530 Subject: [PATCH 3/7] remove redirection to file --- scripts/vet.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/vet.sh b/scripts/vet.sh index 7c7a9b11f8e7..daf5fc72da59 100755 --- a/scripts/vet.sh +++ b/scripts/vet.sh @@ -97,7 +97,7 @@ for MOD_FILE in $(find . -name 'go.mod'); do staticcheck -go 1.21 -checks 'all' ./... >"${SC_OUT}" || true # - Collection of revive linter analysis checks - echo $(revive -formatter friendly $MOD_DIR/...) || true + revive -formatter friendly $MOD_DIR/... || true # Error for anything other than checks that need exclusions. noret_grep -v "(ST1000)" "${SC_OUT}" | noret_grep -v "(SA1019)" | noret_grep -v "(ST1003)" | noret_grep -v "(ST1019)\|\(other import of\)" | not grep -v "(SA4000)" From 941218fa1a4a5f2fafc13900c1f82feb6c243043 Mon Sep 17 00:00:00 2001 From: Purnesh Dixit Date: Thu, 1 Aug 2024 23:56:08 +0530 Subject: [PATCH 4/7] print the revive output --- scripts/vet.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/vet.sh b/scripts/vet.sh index daf5fc72da59..9f8702ea4505 100755 --- a/scripts/vet.sh +++ b/scripts/vet.sh @@ -96,9 +96,6 @@ for MOD_FILE in $(find . -name 'go.mod'); do SC_OUT="$(mktemp)" staticcheck -go 1.21 -checks 'all' ./... >"${SC_OUT}" || true - # - Collection of revive linter analysis checks - revive -formatter friendly $MOD_DIR/... || true - # Error for anything other than checks that need exclusions. noret_grep -v "(ST1000)" "${SC_OUT}" | noret_grep -v "(SA1019)" | noret_grep -v "(ST1003)" | noret_grep -v "(ST1019)\|\(other import of\)" | not grep -v "(SA4000)" @@ -171,4 +168,8 @@ XXXXX PleaseIgnoreUnused' popd done +# Print the revive linter analysis checks +# TODO: Fail if any checks are failing once existing issues are fixed. +revive -formatter friendly ./... + echo SUCCESS From 8a5fd4c5af486cfb4de574f417f1fcdc00e2011f Mon Sep 17 00:00:00 2001 From: Purnesh Dixit Date: Fri, 2 Aug 2024 01:43:57 +0530 Subject: [PATCH 5/7] default formatter to grep easily --- scripts/vet.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/scripts/vet.sh b/scripts/vet.sh index 9f8702ea4505..a15a51e588e9 100755 --- a/scripts/vet.sh +++ b/scripts/vet.sh @@ -168,8 +168,10 @@ XXXXX PleaseIgnoreUnused' popd done -# Print the revive linter analysis checks -# TODO: Fail if any checks are failing once existing issues are fixed. -revive -formatter friendly ./... +# - Collection of revive linter analysis checks +REV_OUT="$(mktemp)" +revive -formatter unix ./... >"${REV_OUT}" || true + +(noret_grep "[unused-parameter]" "${REV_OUT}" | not grep -v "\.pb\.go:") || true echo SUCCESS From da7bdc52ed8b8301fd98dd6a1a95ec2828b99db3 Mon Sep 17 00:00:00 2001 From: Purnesh Dixit Date: Fri, 2 Aug 2024 02:08:47 +0530 Subject: [PATCH 6/7] exclude unused-parameter --- scripts/vet.sh | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/scripts/vet.sh b/scripts/vet.sh index a15a51e588e9..5af619b2a111 100755 --- a/scripts/vet.sh +++ b/scripts/vet.sh @@ -168,10 +168,14 @@ XXXXX PleaseIgnoreUnused' popd done -# - Collection of revive linter analysis checks +# Collection of revive linter analysis checks REV_OUT="$(mktemp)" -revive -formatter unix ./... >"${REV_OUT}" || true +revive -formatter plain ./... >"${REV_OUT}" || true -(noret_grep "[unused-parameter]" "${REV_OUT}" | not grep -v "\.pb\.go:") || true +# Error for anything other than checks that need exclusions. +noret_grep -v "unused" "${REV_OUT}" | not grep -v "\.pb\.go:" + +# Exclude exported linter checks for generated code. +#(noret_grep "exported" "${REV_OUT}" | noret_grep "var-naming" "${REV_OUT}" | noret_grep "redefines-builtin-id" "${REV_OUT}" | noret_grep "package-comments" "${REV_OUT}" | noret_grep "empty-block" "${REV_OUT}" | noret_grep "var-declaration" "${REV_OUT}" | noret_grep "indent-error-flow" "${REV_OUT}" | noret_grep "increment-decrement" "${REV_OUT}" | noret_grep -v "context-as-argument" "${REV_OUT}" | noret_grep -v "context-as-argument" "${REV_OUT}" | not grep -v "\.pb\.go:") || true echo SUCCESS From b8af6c496ccdff01a6f17b39e8dd4bb67b575b0c Mon Sep 17 00:00:00 2001 From: Purnesh Dixit Date: Fri, 2 Aug 2024 02:37:23 +0530 Subject: [PATCH 7/7] plain formatter for excluding only unused-parameter --- scripts/vet.sh | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/scripts/vet.sh b/scripts/vet.sh index 5af619b2a111..92b0b6f067cb 100755 --- a/scripts/vet.sh +++ b/scripts/vet.sh @@ -172,10 +172,8 @@ done REV_OUT="$(mktemp)" revive -formatter plain ./... >"${REV_OUT}" || true -# Error for anything other than checks that need exclusions. -noret_grep -v "unused" "${REV_OUT}" | not grep -v "\.pb\.go:" - -# Exclude exported linter checks for generated code. -#(noret_grep "exported" "${REV_OUT}" | noret_grep "var-naming" "${REV_OUT}" | noret_grep "redefines-builtin-id" "${REV_OUT}" | noret_grep "package-comments" "${REV_OUT}" | noret_grep "empty-block" "${REV_OUT}" | noret_grep "var-declaration" "${REV_OUT}" | noret_grep "indent-error-flow" "${REV_OUT}" | noret_grep "increment-decrement" "${REV_OUT}" | noret_grep -v "context-as-argument" "${REV_OUT}" | noret_grep -v "context-as-argument" "${REV_OUT}" | not grep -v "\.pb\.go:") || true +# Error for anything other than unused-parameter linter check and in generated code. +# TODO: Remove `|| true` to unskip linter failures once existing issues are fixed. +(noret_grep -v "unused-parameter" "${REV_OUT}" | not grep -v "\.pb\.go:") || true echo SUCCESS