From 677959b266818aad8c9cd0f46a1b97f108983112 Mon Sep 17 00:00:00 2001 From: Doug Fawley Date: Mon, 1 Jul 2024 09:04:55 -0700 Subject: [PATCH 1/2] metadata: remove String method --- metadata/metadata.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/metadata/metadata.go b/metadata/metadata.go index 25a8b474b6f2..1e9485fd6e26 100644 --- a/metadata/metadata.go +++ b/metadata/metadata.go @@ -90,12 +90,6 @@ func Pairs(kv ...string) MD { return md } -// String implements fmt.Stringer to allow metadata to be printed when stored -// in a context. It returns the metadata map as formatted by Go's fmt package. -func (md MD) String() string { - return fmt.Sprint(map[string][]string(md)) -} - // Len returns the number of items in md. func (md MD) Len() int { return len(md) From 5423f2dcebc2a18b2378a49c543bc2a8f9d1ebd1 Mon Sep 17 00:00:00 2001 From: Doug Fawley Date: Mon, 1 Jul 2024 09:17:39 -0700 Subject: [PATCH 2/2] rm tests --- metadata/metadata_test.go | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/metadata/metadata_test.go b/metadata/metadata_test.go index 4e0e7abcc442..fbee086fb919 100644 --- a/metadata/metadata_test.go +++ b/metadata/metadata_test.go @@ -338,26 +338,6 @@ func (s) TestAppendToOutgoingContext_FromKVSlice(t *testing.T) { } } -func TestStringerMD(t *testing.T) { - for _, test := range []struct { - md MD - want string - }{ - {MD{}, "map[]"}, - {MD{"k1": []string{}}, "map[k1:[]]"}, - {MD{"k1": []string{"v1", "v2"}}, "map[k1:[v1 v2]]"}, - {MD{"k1": []string{"v1"}}, "map[k1:[v1]]"}, - {MD{"k1": []string{"v1", "v2"}, "k2": []string{}, "k3": []string{"1", "2", "3"}}, "map[k1:[v1 v2] k2:[] k3:[1 2 3]]"}, - {MD{"k2": []string{}, "k3": []string{"1", "2", "3"}, "k1": []string{"v1", "v2"}}, "map[k1:[v1 v2] k2:[] k3:[1 2 3]]"}, - {MD{"k3": []string{"1", "2", "3"}, "k2": []string{}, "k1": []string{"v1", "v2"}}, "map[k1:[v1 v2] k2:[] k3:[1 2 3]]"}, - } { - got := test.md.String() - if got != test.want { - t.Fatalf("Metadata string %q should be %q", got, test.want) - } - } -} - // Old/slow approach to adding metadata to context func Benchmark_AddingMetadata_ContextManipulationApproach(b *testing.B) { // TODO: Add in N=1-100 tests once Go1.6 support is removed.