test: Update transaction_tests and associated JSON files from upstream #2341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
These can be squashed further if desirable |
barton2526
force-pushed
the
tx_invalid
branch
from
78e09c2 to
00b331c
Compare
Member
Author
|
I have added transaction_tests.cpp to this PR, but found a problem: Gridcoin-Research/src/test/transaction_tests.cpp Lines 20 to 21 in 27a6a6a Turns out none of these tests have actually been running for four years :| Blame traces to #236 |
barton2526
force-pushed
the
tx_invalid
branch
from
00b331c to
665b033
Compare
…move P2SH CHECKMULTISIG # of signatures limit
barton2526
force-pushed
the
tx_invalid
branch
from
665b033 to
5601f2b
Compare
barton2526
changed the title
Member
Author
|
Now that #2350 is merged, this should be ready for review. |
Member
Author
|
Closed in favor of #2356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix text for null tx input, Add DERSIG transaction test cases
Ref: [Test Suite] Fix test for null tx input bitcoin/bitcoin#6863
Ref: Add DERSIG transaction test cases bitcoin/bitcoin#6848
Test OP_CODESEPARATOR and FindAndDelete()
Ref: Test OP_CODESEPARATOR and FindAndDelete() bitcoin/bitcoin#3861
Test unexecuted OP_CODESEPARATOR, Fix CHECKMULTISIG mutability and remove P2SH CHECKMULTISIG # of signatures limit
Ref: Test unexecuted OP_CODESEPARATOR bitcoin/bitcoin#5421
Ref: Fix CHECKMULTISIG mutability and remove P2SH CHECKMULTISIG # of signatures limit bitcoin/bitcoin#3843
Add more (misc) tests
Ref: Add more data-driven tests. bitcoin/bitcoin#3601