Skip to content

gui: Update Qt Linguist localization files #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jamescowens merged 3 commits into from
Mar 19, 2021
Merged

gui: Update Qt Linguist localization files #2063

jamescowens merged 3 commits into from
Mar 19, 2021

Conversation

@cyrossignol
Copy link
Member

@cyrossignol cyrossignol commented Mar 18, 2021 •
edited
Loading

Been a while since we did this housekeeping. This fixes a few wording/formatting issues with display strings and regenerates the Qt Linguist translation units to prepare for Transifex integration.

Closes #2062.

@cyrossignol cyrossignol marked this pull request as draft March 18, 2021 19:00
@cyrossignol
Copy link
Member Author

cyrossignol commented Mar 18, 2021

Putting into draft mode. A contributor worked on a particular language that we may want to merge before blasting the repo with conflicts.

@DjMVeiga
Copy link
Contributor

DjMVeiga commented Mar 18, 2021

Hello cyrossignol.
2 years passed since my last translation on Gridcoin and ive tried to commit a change today but im a noob on Github.
Im a BOINC translator for more than 7 years and im used to transifex. Will need to explore github system.
Ive not finished the translation since you've said youre going to do some changes to the files. Can you warn about when that is done so i can finish my translation correctly and 100% well done.

Thanks
Miguel

@jamescowens
Copy link
Member

jamescowens commented Mar 18, 2021

@DjMVeiga Hey. @cyrossignol hooked up the Transifex integration to the repo today...
https://github.com/gridcoin-community/Gridcoin-Research/settings/installations

@DjMVeiga
Copy link
Contributor

DjMVeiga commented Mar 18, 2021

@DjMVeiga Hey. @cyrossignol hooked up the Transifex integration to the repo today...
https://github.com/gridcoin-community/Gridcoin-Research/settings/installations

Amazing. Im more an app translator than a developer. Would be amazing if the changes ive did today can be already commited so i dont need to done it again. Thanks

@DjMVeiga
Copy link
Contributor

DjMVeiga commented Mar 18, 2021

Will wait that i can do it directly on transifex or will study more the github system

@cyrossignol cyrossignol force-pushed the update-translations branch from e61ff28 to 7f69905 Compare March 18, 2021 22:51
@cyrossignol
Copy link
Member Author

cyrossignol commented Mar 18, 2021

@DjMVeiga This looks like excellent work. I'm impressed by your commitment to update the XML files directly! Of course, I don't speak Portuguese, so I cannot review your changes, but I pulled your commit into my branch, and I made some small tweaks to fix some XML syntax issues. It will merge with this pull request.

When this finishes, translators can begin to contribute to the Gridcoin project on Transifex.

@cyrossignol cyrossignol marked this pull request as ready for review March 18, 2021 23:00
@DjMVeiga
Copy link
Contributor

DjMVeiga commented Mar 18, 2021 •
edited
Loading

Thanks cyrossignol. I'm used to do apps translations, so i love to do that.
However ,theres been 2 years since the initial translations when Gridcoin was still a child and many changes happened so far.
I understand the xml code, so thats not a problem at all. My problem was with the github system. In the beggining in my first translations, Gridcoin was not even on Github i think. All i did was directly in contact with IRC users.
Anway , if you're going to start using Transifex, that will be amazing as Transifex is a specialized system for that and more user friendly for translators. Githuh is more for developers and as i told before, i do translations as an hobbie and not a developer. I work as a Systems Administrator but i really like to do App translations.

Best regards and whatever i can do to help Gridcoin grow, you can alway count on me

@cyrossignol cyrossignol mentioned this pull request Mar 19, 2021
Closed
@cyrossignol
Copy link
Member Author

cyrossignol commented Mar 19, 2021

@DjMVeiga I agree—GitHub is not a very good tool to manage translations with. Transifex looks much better, and I've been meaning to set it up for a while. Your message in IRC reminded me to look at it again. I'm new to this platform, though, so I hope you can offer advice as we set up the project.

I accepted your request to join as a translator. Please wait for this pull request to merge before submitting changes. Thanks for the contributions!

jamescowens
jamescowens approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@jamescowens jamescowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

@jamescowens jamescowens added this to the Ingrid milestone Mar 19, 2021
@jamescowens jamescowens merged commit da41d7d into gridcoin-community:development Mar 19, 2021
@cyrossignol cyrossignol deleted the update-translations branch March 19, 2021 03:15
@DjMVeiga
Copy link
Contributor

DjMVeiga commented Mar 19, 2021

@DjMVeiga I agree—GitHub is not a very good tool to manage translations with. Transifex looks much better, and I've been meaning to set it up for a while. Your message in IRC reminded me to look at it again. I'm new to this platform, though, so I hope you can offer advice as we set up the project.

I accepted your request to join as a translator. Please wait for this pull request to merge before submitting changes. Thanks for the contributions!

Thanks, will do the translation as soon as the files are ready.
Other thing, dont add me as Brasilian Translator. Portuguese from Portuguese and Brasil are tottaly different in the way certain words and sentences are written. Both are Portuguese but still very different. We both understand from each other but i cannot translate into Portuguese from Portugal as im Native from Portugal.

Best regards

@DjMVeiga
Copy link
Contributor

DjMVeiga commented Mar 19, 2021 •
edited
Loading

@DjMVeiga I agree—GitHub is not a very good tool to manage translations with. Transifex looks much better, and I've been meaning to set it up for a while. Your message in IRC reminded me to look at it again. I'm new to this platform, though, so I hope you can offer advice as we set up the project.

I accepted your request to join as a translator. Please wait for this pull request to merge before submitting changes. Thanks for the contributions!

Also, you can add give me permissions also to review, as in transifex you can have the privileges to translate but also to review.
So after someone translate, theres should be someone to review the file. Otherwise the file is not considered as complete. If you agree as for now theres not anyone else to translate Portuguese (Portugal), ill translate and review all the content. I'm also a translator and reviewer in BOINC, so im used to that.
Also theres a good way to check what i've reviewed, as the project is new so its 100% not reviewed. That way i will recheck everything and not only what is not translated.

So when you can please do that changes: remove me as Portuguese (Brasil) translator and give me the translator and reviewer permissions to Portuguese (Portugal)

@cyrossignol
Copy link
Member Author

cyrossignol commented Mar 19, 2021

@DjMVeiga Thanks for the tips. I made the changes that you suggested.

@DjMVeiga
Copy link
Contributor

DjMVeiga commented Mar 19, 2021

@DjMVeiga Thanks for the tips. I made the changes that you suggested.

Hi again.
You add me as a reviewer but removed me as translator. I have to have both permissions.
Can you fix it please? Thanks

@cyrossignol
Copy link
Member Author

cyrossignol commented Mar 20, 2021

@DjMVeiga Sorry about that. When I assigned the "reviewer" role to you, Transifex automatically removed your "translator" role. According to the Transifex documentation, though, a reviewer can work on translations as well. Is that not true?

I invited you you to the translator role again. Please let me know if that fixes the issue.

@DjMVeiga
Copy link
Contributor

DjMVeiga commented Mar 20, 2021

@DjMVeiga Sorry about that. When I assigned the "reviewer" role to you, Transifex automatically removed your "translator" role. According to the Transifex documentation, though, a reviewer can work on translations as well. Is that not true?

I invited you you to the translator role again. Please let me know if that fixes the issue.

All working now.
Thanks a lot

Will finish it this weekend

@DjMVeiga
Copy link
Contributor

DjMVeiga commented Mar 25, 2021

Translation done.
Well 95% but it can be considered 100%
Is there a way to appl the locale file on installed gridcoin on my machine so i can test several phrases to check if theyre ok considering the context. Can't file where the local files are installed on local disk

@iFoggz
Copy link
Member

iFoggz commented Mar 25, 2021

Everything is compiled into the application at compile time.

@DjMVeiga
Copy link
Contributor

DjMVeiga commented Mar 25, 2021

Everything is compiled into the application at compile time.

is there a way to get a compiled version with language PT_pt already applied with the changes done on transifex?

@iFoggz
Copy link
Member

iFoggz commented Mar 25, 2021

I personally know nothing about transifex so cy would have to comment on that

@DjMVeiga
Copy link
Contributor

DjMVeiga commented Mar 25, 2021

@DjMVeiga Sorry about that. When I assigned the "reviewer" role to you, Transifex automatically removed your "translator" role. According to the Transifex documentation, though, a reviewer can work on translations as well. Is that not true?

I invited you you to the translator role again. Please let me know if that fixes the issue.

Know that ive done 95% of my translation, is there a way to have a compiled version of Gridcoin with the tanslation already there, so i can fix eventual words or phrases out of context. Some work has to be done directly on the app, checking the tranlsation applied

@jamescowens
Copy link
Member

jamescowens commented Mar 27, 2021

Yes. I can give you a build based on the PR. What platform do you use?

@DjMVeiga
Copy link
Contributor

DjMVeiga commented Mar 27, 2021

Yes. I can give you a build based on the PR. What platform do you use?

Windows 10 - 64bits

jamescowens added a commit to jamescowens/Gridcoin-Research that referenced this pull request Apr 4, 2021
@jamescowens
5.3.1.0, 2021-04-04, leisure
afbf5c1 
Added
 - doc: Invite users to donate to Gridcoin Foundation gridcoin-community#1997 (@smoe)
 - rpc: Add "getburnreport" RPC function gridcoin-community#2049 (@cyrossignol)
 - doc: Add undocumented "-showorphans" GUI option to help text gridcoin-community#2058 (@cyrossignol)
 - beacon: Cull beacon db memory (passivation) gridcoin-community#2069 (@jamescowens)
 - gui: Avoid refreshing GUI researcher status while out-of-sync gridcoin-community#2068 (@cyrossignol)
 - consensus: Reimplement checkpoint-based spam protection gridcoin-community#2084 (@cyrossignol)
 - consensus: Verify hardened checkpoints on start up gridcoin-community#2087 (@cyrossignol)

Changed
 - gui: Clarify overview page "stake" field gridcoin-community#2056 (@cyrossignol)
 - doc: Update Copyright headers gridcoin-community#2059 (@barton2526)
 - gui: Update Qt Linguist localization files gridcoin-community#2063 (@cyrossignol)
 - build: update dependencies gridcoin-community#2064 (@barton2526)
 - net: Reduce default connection limit back to 125 gridcoin-community#2066 (@cyrossignol)
 - build: openssl patch gridcoin-community#2074 (@barton2526)
 - translation: Translate /src/qt/locale/bitcoin_en.ts in pt_PT gridcoin-community#2083 (@DjMVeiga)
 - log: Adjust logging gridcoin-community#2076 (@jamescowens)
 - gui: Change scraper tab to Inconsolata monospace font gridcoin-community#2085 (@jamescowens)
 - researcher: Change beacon deferment fix to reference nActiveBeforeSB gridcoin-community#2092 (@jamescowens)

Removed
 - net: Clean up mandatory protocol version transition gridcoin-community#2080 (@cyrossignol)
 - refactor: Remove LessVerbose() function gridcoin-community#2089 (@cyrossignol)

Fixed
 - beacon: Fix a subtle error in renewal chain walker gridcoin-community#2054 (@jamescowens)
 - researcher: Fix "malformed CPID" status for some pool projects gridcoin-community#2052 (@cyrossignol)
 - lint: Misc Typos gridcoin-community#2060 (@barton2526)
 - lint: remove identified duplicate includes gridcoin-community#2061 (@barton2526)
 - gui: Fix splash screen block height progress gridcoin-community#2057 (@cyrossignol)
 - gui: Fix garbage placeholders in some tx notification localizations gridcoin-community#2070 (@cyrossignol)
 - build: Patch libzip to fix mingw compile regression for mingw 9.2+ gridcoin-community#2082 (@jamescowens)
 - gui: Fix shutdown response for failed core init gridcoin-community#2088 (@cyrossignol)
 - researcher: Fix deferment of beacon renewal in superblock window gridcoin-community#2090 (@cyrossignol)
 - gui: Fix typo in beacon status refresh gridcoin-community#2091 (@div72)
jamescowens added a commit to jamescowens/Gridcoin-Research that referenced this pull request Apr 4, 2021
@jamescowens
5.3.1.0, 2021-04-04, leisure
7a5a96f 
Added
 - doc: Invite users to donate to Gridcoin Foundation gridcoin-community#1997 (@smoe)
 - rpc: Add "getburnreport" RPC function gridcoin-community#2049 (@cyrossignol)
 - gui: Add stats export reminder to beacon wizard auth page gridcoin-community#2050 (@cyrossignol)
 - doc: Add undocumented "-showorphans" GUI option to help text gridcoin-community#2058 (@cyrossignol)
 - beacon: Cull beacon db memory (passivation) gridcoin-community#2069 (@jamescowens)
 - gui: Avoid refreshing GUI researcher status while out-of-sync gridcoin-community#2068 (@cyrossignol)
 - consensus: Reimplement checkpoint-based spam protection gridcoin-community#2084 (@cyrossignol)
 - consensus: Verify hardened checkpoints on start up gridcoin-community#2087 (@cyrossignol)

Changed
 - test: autogenerate data headers gridcoin-community#2030 (@div72)
 - doc: Change copyright years to 2021 gridcoin-community#2042 (@caraka)
 - gui: Clarify overview page "stake" field gridcoin-community#2056 (@cyrossignol)
 - doc: Update Copyright headers gridcoin-community#2059 (@barton2526)
 - gui: Update Qt Linguist localization files gridcoin-community#2063 (@cyrossignol)
 - build: update dependencies gridcoin-community#2064 (@barton2526)
 - net: Reduce default connection limit back to 125 gridcoin-community#2066 (@cyrossignol)
 - build: openssl patch gridcoin-community#2074 (@barton2526)
 - translation: Translate /src/qt/locale/bitcoin_en.ts in pt_PT gridcoin-community#2083 (@DjMVeiga)
 - log: Adjust logging gridcoin-community#2076 (@jamescowens)
 - gui: Change scraper tab to Inconsolata monospace font gridcoin-community#2085 (@jamescowens)
 - researcher: Change beacon deferment fix to reference nActiveBeforeSB gridcoin-community#2092 (@jamescowens)

Removed
 - net: Clean up mandatory protocol version transition gridcoin-community#2080 (@cyrossignol)
 - refactor: Remove LessVerbose() function gridcoin-community#2089 (@cyrossignol)

Fixed
 - build: Fix depends cross-compilation for macOS gridcoin-community#2038 (@cyrossignol)
 - build: Deal with Qt depends .qmake.stash file gridcoin-community#2048 (@cyrossignol)
 - beacon: Fix a subtle error in renewal chain walker gridcoin-community#2054 (@jamescowens)
 - researcher: Fix "malformed CPID" status for some pool projects gridcoin-community#2052 (@cyrossignol)
 - lint: Misc Typos gridcoin-community#2060 (@barton2526)
 - lint: remove identified duplicate includes gridcoin-community#2061 (@barton2526)
 - gui: Fix splash screen block height progress gridcoin-community#2057 (@cyrossignol)
 - gui: Fix garbage placeholders in some tx notification localizations gridcoin-community#2070 (@cyrossignol)
 - build: Patch libzip to fix mingw compile regression for mingw 9.2+ gridcoin-community#2082 (@jamescowens)
 - gui: Fix shutdown response for failed core init gridcoin-community#2088 (@cyrossignol)
 - researcher: Fix deferment of beacon renewal in superblock window gridcoin-community#2090 (@cyrossignol)
 - gui: Fix typo in beacon status refresh gridcoin-community#2091 (@div72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamescowens jamescowens jamescowens approved these changes

Assignees

@cyrossignol cyrossignol

Labels

enhancement

Projects

None yet

Milestone

Ingrid

Development

Successfully merging this pull request may close these issues.

Typo - console [archivelog]. Change 'valus' to 'values'

4 participants

@cyrossignol @DjMVeiga @jamescowens @iFoggz