use flow-dynamic to check resolver,and link them to Flow

Author: iamchenxin

package.json

@@ -58,6 +58,8 @@
     "coveralls": "2.11.9",
     "eslint": "2.10.2",
     "flow-bin": "0.25.0",
+    "flow-dynamic": "^0.0.9",
+    "flow-graphql": "^0.6.4",
     "graphql": "0.6.0",
     "isparta": "4.0.0",
     "mocha": "2.5.3",

src/mutation/__tests__/mutation.js

@@ -65,7 +65,8 @@ var simpleRootValueMutation = mutationWithClientMutationId({
       type: GraphQLInt
     }
   },
-  mutateAndGetPayload: (params, context, {rootValue}) => (rootValue)
+  // :any to ignore type check in test.
+  mutateAndGetPayload: (params, context, {rootValue}) => ((rootValue:any))
 });
 
 var mutation = new GraphQLObjectType({

src/mutation/mutation.js

@@ -22,6 +22,12 @@ import type {
   GraphQLResolveInfo
 } from 'graphql';
 
+import {
+  graph,
+  pro
+} from 'flow-dynamic';
+const {argsCheck} = graph;
+
 type mutationFn = (object: Object, ctx: mixed, info: GraphQLResolveInfo) =>
   ( Object | Promise<Object> );
 
@@ -86,12 +92,16 @@ export function mutationWithClientMutationId(
     args: {
       input: {type: new GraphQLNonNull(inputType)}
     },
-    resolve: (_, {input}, context, info) => {
-      return Promise.resolve(mutateAndGetPayload(input, context, info))
-        .then(payload => {
-          payload.clientMutationId = input.clientMutationId;
-          return payload;
-        });
-    }
+    resolve: argsCheck(
+      args => ({
+        input: pro.isObject(args.input)
+      }),
+      (_, {input}, context, info) => {
+        return Promise.resolve(mutateAndGetPayload(input, context, info))
+          .then(payload => {
+            payload.clientMutationId = input.clientMutationId;
+            return payload;
+          });
+      })
   };
 }

src/node/__tests__/plural.js

@@ -48,10 +48,11 @@ var queryType = new GraphQLObjectType({
       description: 'Map from a username to the user',
       inputType: GraphQLString,
       outputType: userType,
-      // $FlowFixMe : rootValue Graphql(mixed) -> relay(object)
-      resolveSingleInput: (username, context, {rootValue: {lang}}) => ({
+      // rootValue Graphql(mixed) -> relay(object)
+      // :any to ignore type check in test.
+      resolveSingleInput: (username, context, {rootValue}) => ({
         username: username,
-        url: 'www.facebook.com/' + username + '?lang=' + lang
+        url: 'www.facebook.com/' + username + '?lang=' + (rootValue:any).lang
       })
     })
   })

src/node/node.js

@@ -25,6 +25,12 @@ import {
   unbase64
 } from '../utils/base64.js';
 
+import {
+  graph,
+  pro
+} from 'flow-dynamic';
+const {argsCheck, sourceCheck} = graph;
+
 type GraphQLNodeDefinitions = {
   nodeInterface: GraphQLInterfaceType,
   nodeField: GraphQLFieldConfig
@@ -58,6 +64,8 @@ export function nodeDefinitions(
     resolveType: typeResolver
   });
 
+
+
   var nodeField = {
     name: 'node',
     description: 'Fetches an object given its ID',
@@ -68,7 +76,11 @@ export function nodeDefinitions(
         description: 'The ID of an object'
       }
     },
-    resolve: (obj, {id}, context, info) => idFetcher(id, context, info),
+    //  type NodeArgs = {id:string};
+    resolve: argsCheck(
+      args => ({id: pro.isString(args.id) }),
+      (obj, args, context, info) => idFetcher(args.id, context, info)
+    )
   };
 
   return {nodeInterface, nodeField};
@@ -114,9 +126,12 @@ export function globalIdField(
     name: 'id',
     description: 'The ID of an object',
     type: new GraphQLNonNull(GraphQLID),
-    resolve: (obj, args, context, info) => toGlobalId(
-      typeName || info.parentType.name,
-      idFetcher ? idFetcher(obj, context, info) : obj.id
+    resolve: sourceCheck(
+      obj => pro.isObject(obj),
+      (obj, args, context, info) => toGlobalId(
+        typeName || info.parentType.name,
+        idFetcher ? idFetcher(obj, context, info) : obj.id
+      )
     )
   };
 }

src/node/plural.js

@@ -23,6 +23,12 @@ import type {
   GraphQLInputObjectType
 } from 'graphql';
 
+import {
+  graph,
+  pro
+} from 'flow-dynamic';
+const {argsCheck} = graph;
+
 type PluralIdentifyingRootFieldConfig = {
   argName: string,
   inputType: GraphQLInputType,
@@ -47,14 +53,16 @@ export function pluralIdentifyingRootField(
     description: config.description,
     type: new GraphQLList(config.outputType),
     args: inputArgs,
-    resolve: (obj, args, context, info) => {
-      var inputs = args[config.argName];
-      return Promise.all(inputs.map(
-        input => Promise.resolve(
-          config.resolveSingleInput(input, context, info)
-        )
-      ));
-    }
+    resolve: argsCheck( args => pro.isObject(args),
+      (obj, args, context, info) => {
+        var inputs = args[config.argName];
+        return Promise.all(inputs.map(
+          input => Promise.resolve(
+            config.resolveSingleInput(input, context, info)
+          )
+        ));
+      }
+    )
   };
 }